Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix haskell-src-meta patch URI #75594

Closed
wants to merge 1 commit into from
Closed

Fix haskell-src-meta patch URI #75594

wants to merge 1 commit into from

Conversation

@dfordivam
Copy link
Contributor

@dfordivam dfordivam commented Dec 13, 2019

Motivation for this change

The current URI is not available anymore, this commit just points to the correct file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@peti
Copy link
Member

@peti peti commented Dec 13, 2019

@GrahamcOfBorg haskell.packages.ghc881.haskell-src-meta

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Dec 13, 2019

@dfordivam The reason these patches are using /master/ instead of an actual commit to the patch file is so that we can easily(?) figure out when the patch is no longer needed.

When an updated version of the upstream package is released to Hackage, then the patch gets deleted from head.hackage.

This is a sign for us to drop the patch.


In this case, it appears that a new release of haskell-src-meta has been made that supports ghc-8.8.1, so we no longer need this patch.

Can you update this PR to just drop the patch?

peti added a commit that referenced this pull request Dec 13, 2019
This allows us to build the package without the need for
patching. The test suite still doesn't compile unfortunately.

Closes #75594.
@peti
Copy link
Member

@peti peti commented Dec 13, 2019

Fixed in 30c033c.

@peti peti closed this Dec 13, 2019
peti added a commit that referenced this pull request Dec 13, 2019
This allows us to build the package without the need for
patching. The test suite still doesn't compile unfortunately.

Closes #75594.
peti added a commit that referenced this pull request Dec 13, 2019
This allows us to build the package without the need for
patching. The test suite still doesn't compile unfortunately.

Closes #75594.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.