Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manylinux packages #75596

Merged
merged 1 commit into from Dec 13, 2019
Merged

Fix manylinux packages #75596

merged 1 commit into from Dec 13, 2019

Conversation

@gilligan
Copy link
Contributor

@gilligan gilligan commented Dec 13, 2019

Motivation for this change

This makes sure that the lib output is used whenever available. Working on manylinux support for poetry2nix I noticed problems with missing libraries and realized this was because some of the buildInputs where the bin outputs and thus patching via autoPatchelfHook failed.

Things done

Applying lib.getLib` to make sure we get the library outputs as buildInputs. I tested that it actually works with my WIP poetry2nix code.

@gilligan gilligan requested a review from FRidh as a code owner Dec 13, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 13, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Dec 13, 2019

Good improvement, thanks. The let ... in are not needed though.

@gilligan gilligan force-pushed the gilligan:fix-manylinux branch from 73e8f11 to 2e6dc7c Dec 13, 2019
Make sure lib outputs are used where applicable.
@gilligan gilligan force-pushed the gilligan:fix-manylinux branch from 2e6dc7c to 369bfe2 Dec 13, 2019
@gilligan
Copy link
Contributor Author

@gilligan gilligan commented Dec 13, 2019

Thanks for the fast feedback @FRidh

The let ... in are not needed though.

Sure. Fine with me either way. Just removed them.

@FRidh FRidh merged commit 418ad57 into NixOS:master Dec 13, 2019
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.