Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: pyspf: 2.0.13 -> 2.0.14pre1 #75604

Merged
merged 1 commit into from Jan 7, 2020
Merged

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Dec 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @jonringer

@petabyteboy petabyteboy requested review from FRidh and jonringer as code owners Dec 13, 2019
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Dec 13, 2019

@FRidh
Copy link
Member

@FRidh FRidh commented Dec 13, 2019

Why not fix 2.0.13?

@ofborg ofborg bot added the 6.topic: python label Dec 13, 2019
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Dec 13, 2019

Fixing 2.0.13 would also be fine for me

@spacekookie
Copy link
Member

@spacekookie spacekookie commented Dec 13, 2019

Why not fix 2.0.13?

While that would be the better approach, I feel it might be important to people depending on unstable to get a working config back

@petabyteboy petabyteboy force-pushed the petabyteboy:feature/pyspf branch from b4b4bca to d249f58 Dec 13, 2019
@petabyteboy petabyteboy changed the title Revert "python: pyspf: 2.0.12 -> 2.0.13" python: pyspf: 2.0.13 -> 2.0.14pre1 Dec 13, 2019
@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Dec 13, 2019

I have changed this PR to update to 2.0.14pre1, which includes the fix.

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM

[5 built, 3 copied (0.4 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75604
4 package were built:
pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 16, 2019

@GrahamcOfBorg build pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf

@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Jan 7, 2020

This must be merged or fixed otherwise before 20.03.
I am a bit frustrated with this issue, because it was broken, fixed, broken again and this fix was first criticised, then changed to match the criticism and now it is not being merged. I can apply the patch to my nixpkgs branch for my machines, but I can not recommend to anyone to run a mail server with NixOS if they have to manually apply patches to Nixpkgs to make it work properly.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020

@GrahamcOfBorg build pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020

with a limited number of people for reviewing, it's hard to keep up with the wave of PRs, bumping helps in cases like this

@jonringer jonringer merged commit fe2742c into NixOS:master Jan 7, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on aarch64-linux Success
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on x86_64-darwin Success
Details
pypolicyd-spf, python27Packages.pyspf, python37Packages.pyspf, python38Packages.pyspf on x86_64-linux Success
Details
python on aarch64-linux Success
Details
python on x86_64-linux Success
Details
@jonringer jonringer mentioned this pull request Jan 7, 2020
5 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.