Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcide: unbreak #75610

Closed
wants to merge 20 commits into from
Closed

ghcide: unbreak #75610

wants to merge 20 commits into from

Conversation

@mdorman
Copy link
Contributor

@mdorman mdorman commented Dec 13, 2019

Motivation for this change

Enable the ghcide package to build again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

peti and others added 20 commits Dec 7, 2019
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@12e9d05.
haskell-spacecookie: fix build
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@bc63f2b.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@313fea6.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@b8d7b39.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@0c789b9.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@a79a474.
Unbreak haskellPackages.clay
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@662da93.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@3cc3cc2.
This update was generated by hackage2nix v2.15.0-9-g650d530 from Hackage revision
commercialhaskell/all-cabal-hashes@322132d.
First, update the hackage2nix configuration to not mark it broken
automatically.

Then make sure the packages it depends on---haskell-lsp-types,
haskell-lsp and lsp-test---are depending on appropriate versions of
one another, and then plumb those into ghcide itself.
@mdorman mdorman requested review from basvandijk and cdepillabout as code owners Dec 13, 2019
peti added a commit that referenced this pull request Dec 13, 2019
ghcide needs version 0.18.x of the haskell-lsp package to build.

Closes #75610.
peti added a commit that referenced this pull request Dec 13, 2019
ghcide needs version 0.18.x of the haskell-lsp package to build.

Closes #75610.
@peti peti force-pushed the NixOS:haskell-updates branch from 1aad9e2 to 14b0fb3 Dec 13, 2019
@peti peti force-pushed the NixOS:haskell-updates branch from 14b0fb3 to 9c01e12 Dec 13, 2019
@peti peti closed this in d5814bc Dec 13, 2019
@mdorman mdorman deleted the mdorman:unbreak-ghcide branch Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.