Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: john: disable native tests for john the ripper #75614

wants to merge 10,000 commits into from


Copy link

@scaredmushroom scaredmushroom commented Dec 13, 2019

Motivation for this change

The default.nix of john has a faulty build flag. Through that john is currently not working.
This problem was fixed in master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @

flokli and others added 30 commits Dec 9, 2019
nixosTests.ipv6: port to python
tdb: 1.3.16 -> 1.3.18
phoronix-test-suite: 9.0.1 -> 9.2.0
libredirect: fix argument forwarding in `open*` functions
Since bash-completion rules are loaded dynamically, the completion
rules for `gitk <Tab>` waere not being loaded until the user first
typed `git <Tab>`.  Fix this by adding a symlink named `gitk`.

Signed-off-by: Anders Kaseorg <>
Fixes #75075.

To summarize the report in the aforementioned issue, at a glance,
it's a different default than what upstream polkit has. Apparently
for 8+ years polkit defaults admin identities as members of
the wheel group [0]. This assumption would be appropriate on NixOS, where
every member of group 'wheel' is necessarily privileged.


python38Packages.phonenumbers: 8.10.23 -> 8.11.0
conmon: v2.0.3 -> v2.0.4
rabbitmq-c: 0.9.0 -> 0.10.0
riemann: 0.3.4 -> 0.3.5

python38Packages.pythondialog: 3.4.0 -> 3.5.0
python38Packages.shodan: 1.19.1 -> 1.20.0
python38Packages.ipdb: 0.12.2 -> 0.12.3
gitAndTools.tig: 2.4.1 -> 2.5.0
A centralized list for these renames is not good because:
- It breaks disabledModules for modules that have a rename defined
- Adding/removing renames for a module means having to find them in the
central file
- Merge conflicts due to multiple people editing the central file
ibm-plex: 4.0.1 -> 4.0.2
pulseeffects: 4.6.8 -> 4.6.9
solr: 8.3.0 -> 8.3.1
Move renames to their appropriate places

This comment has been minimized.

I'm a little late to the party but I just noticed the fontconfig options and was wondering if this was a mistake or actually somehow needed in the exporters module? :)

This comment has been minimized.

Copy link
Member Author

@Infinisil Infinisil replied Jun 18, 2020

Oh yeah that looks like a mistake! -> #91065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.