Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacsMacport: Rename emacsVersion attribute to version #75618

Merged
merged 1 commit into from Dec 14, 2019

Conversation

@jsamsa
Copy link
Contributor

@jsamsa jsamsa commented Dec 13, 2019

Changes in #74936 depend on emacs
derivations to have a version attribute.

Motivation for this change

change in #74936 reference "version" attribute in emacs derivations. emacsMacport used "emacsVersion". I found no other references to "emacsVersion" throughout nixpkgs and chose to change the derivation to use version which is in line with the reference found in elpa-packages.nix.

Bug can be reproduced/tested in the repl like so:

nix-repl> :l <nixpkgs>
nix-repl> (emacsPackagesFor emacsMacport).emacsWithPackages(ps: [ ps.seq ])
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • [X ] macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jwiegley @matthewbauer

@jsamsa jsamsa requested a review from adisbladis as a code owner Dec 13, 2019
@jsamsa jsamsa force-pushed the jsamsa:emacsmacport-fix branch from 88ca819 to 7889166 Dec 13, 2019
@jsamsa jsamsa changed the title Rename emacsVersion attribute to version emacsMacport: Rename emacsVersion attribute to version Dec 13, 2019
@adisbladis
Copy link
Member

@adisbladis adisbladis commented Dec 13, 2019

@GrahamcOfBorg build emacsMacport

@jsamsa
Copy link
Contributor Author

@jsamsa jsamsa commented Dec 13, 2019

Here is the error produced before the fix:

error: attribute 'version' missing, at /nix/store/dd3rda2yhmn8qdmpdwz4kqwfh5h8af2w-nixpkgs-20.03pre204216.cc6cf0a96a6/nixpkgs/pkgs/applications/editors/emacs-modes/elpa-packages.nix:43:35

@ofborg ofborg bot added the 6.topic: emacs label Dec 13, 2019
Changes in #74936 depend on emacs
derivations to have a version attribute.
@jsamsa jsamsa force-pushed the jsamsa:emacsmacport-fix branch from 7889166 to 77804ab Dec 13, 2019
@ofborg ofborg bot requested review from jwiegley and matthewbauer Dec 13, 2019
@jsamsa jsamsa requested a review from adisbladis Dec 14, 2019
@adisbladis adisbladis merged commit d3d8b77 into NixOS:master Dec 14, 2019
15 checks passed
15 checks passed
emacsMacport on aarch64-linux No attempt
Details
emacsMacport on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jsamsa jsamsa deleted the jsamsa:emacsmacport-fix branch Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.