Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-history: Add tests #75625

Merged
merged 1 commit into from Dec 15, 2019
Merged

zsh-history: Add tests #75625

merged 1 commit into from Dec 15, 2019

Conversation

@kampka
Copy link
Contributor

kampka commented Dec 13, 2019

Motivation for this change

Adds tests for the zsh-history program and zsh plugin.
See #75622 for reference.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@kampka

This comment has been minimized.

Copy link
Contributor Author

kampka commented Dec 13, 2019

@worldofpeace Sorry for the noise, I can't reopen the old PR for some reason.

This changes ships without the module and a refactored test so that it at least provides a usage example for how to (potentially) use the package.

It feels like there is a meta field missing for those kind of things though.
meta.longDescription seem like more of a general description filed than a field containing literal examples. Do you have any advice on where that kind of documentation should go?

@ofborg ofborg bot added the 6.topic: nixos label Dec 13, 2019
@kampka kampka force-pushed the kampka:zsh-history-module branch from 8479897 to c98d54a Dec 14, 2019
@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Dec 15, 2019

@GrahamcOfBorg test zsh-history

@worldofpeace worldofpeace merged commit 22f57b8 into NixOS:master Dec 15, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.zsh-history on aarch64-linux Success
Details
tests.zsh-history on x86_64-linux Success
Details
zsh-history on aarch64-linux Success
Details
zsh-history on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.