Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 0.29.0 -> 0.30.1 #75637

Closed
wants to merge 1 commit into from
Closed

starship: 0.29.0 -> 0.30.1 #75637

wants to merge 1 commit into from

Conversation

@equirosa
Copy link
Contributor

@equirosa equirosa commented Dec 14, 2019

Motivation for this change

New version is out, bringing some bug fixes.
https://github.com/starship/starship/releases/tag/v0.30.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor

@marsam marsam commented Dec 14, 2019

Addressed by #75629

@marsam marsam closed this Dec 14, 2019
@equirosa equirosa deleted the equirosa:starship branch Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.