Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-twitter: init at 3.5 #75647

Merged
merged 1 commit into from Dec 15, 2019
Merged

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Dec 14, 2019

Motivation for this change

Add https://github.com/bear/python-twitter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested review from FRidh and jonringer as code owners Dec 14, 2019
@marsam
Copy link
Contributor Author

@marsam marsam commented Dec 14, 2019

@GrahamcOfBorg build python3Packages.python-twitter

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commit LGTM
has tests 👍

[6 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75647
3 package were built:
python27Packages.python-twitter python37Packages.python-twitter python38Packages.python-twitter
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 14, 2019

@GrahamcOfBorg build python27Packages.python-twitter python37Packages.python-twitter python38Packages.python-twitter

@marsam marsam merged commit 1784ddb into NixOS:master Dec 15, 2019
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.python-twitter, python37Packages.python-twitter, python38Packages.python-twitter on aarch64-linux Success
Details
python27Packages.python-twitter, python37Packages.python-twitter, python38Packages.python-twitter on x86_64-darwin Success
Details
python27Packages.python-twitter, python37Packages.python-twitter, python38Packages.python-twitter on x86_64-linux Success
Details
python3Packages.python-twitter on aarch64-linux Success
Details
python3Packages.python-twitter on x86_64-linux Success
Details
@marsam marsam deleted the marsam:add-python-twitter branch Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.