Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tipp10: init at 3.1.0 #75664

Closed
wants to merge 1 commit into from
Closed

Conversation

@petabyteboy
Copy link
Member

@petabyteboy petabyteboy commented Dec 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Dec 14, 2019

Tested only on Linux amd64.
It still throws an error about not being able to write to its nix store path at the first start, but then works fine.
Might be interesting for darwin users since the original qt4-based version from tipp10.com is not available for Mac OS Catalina.

@Kloenk
Copy link
Contributor

@Kloenk Kloenk commented Dec 18, 2019

Builds fine, tested basic functionality on NixOS x86_64-linux.

The path warning reshowes when deleting the user DB from the home directory.

@petabyteboy
Copy link
Member Author

@petabyteboy petabyteboy commented Dec 18, 2019

After re-evaluating the warning on initial start of the application seems to be unrelated to Nix/OS and probably appears on all Linux distributions. It merely says that the data directory in the users's home directory doesn't exist and will be created.
So this is ready to go from my side.

@schmittlauch schmittlauch mentioned this pull request Feb 11, 2020
6 of 10 tasks complete
@Mic92 Mic92 closed this in #79848 Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.