Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bless: init at 0.6.2 #75670

Merged
merged 1 commit into from Feb 9, 2020
Merged

bless: init at 0.6.2 #75670

merged 1 commit into from Feb 9, 2020

Conversation

@mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Dec 14, 2019

Motivation for this change

Needed this for myself, might be useful for others, too

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Dec 15, 2019

I've noticed this has several issues when running it on nixOS, didn't notice them at first because I had everything installed on my ubuntu machine.

Need to fix those first

# and it also wants to install that file
touch ./doc/user/bless-manual.omf
./autogen.sh

This comment has been minimized.

@jtojnar

jtojnar Dec 15, 2019
Contributor

Does not preAutoreconf work?

This comment has been minimized.

@mkg20001

mkg20001 Dec 15, 2019
Author Member

I also need to invoke ./autogen.sh because the autoreconfHook calls the tools directly, but the script invokes some more tools that create necessary files.

This comment has been minimized.

@mkg20001

mkg20001 Dec 15, 2019
Author Member

And it seems to work that way, because the prefix is passed via configure phase

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 15, 2019

Ook, I was already looking forward to removing gtk-sharp.

Yeah, also getting some errors:

$ result/bin/bless 
result/bin/bless: line 3: mono: command not found
$ nix run -f '<nixpkgs>' mono -c result/bin/bless

Unhandled Exception:
System.TypeLoadException: Could not load type of field 'BlessMain:DataViewBox' (0) due to: Could not load file or assembly 'gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of its dependencies.
[ERROR] FATAL UNHANDLED EXCEPTION: System.TypeLoadException: Could not load type of field 'BlessMain:DataViewBox' (0) due to: Could not load file or assembly 'gtk-sharp, Version=2.12.0.0, Culture=neutral, PublicKeyToken=35e10195dab3c99f' or one of its dependencies.
@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Dec 19, 2019

Seems like it tries to search for it in $mono and $bless
Is there a way to add search paths via ENV to the list?

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Dec 19, 2019

It talks about LD_LIBRARY_PATH
Current attempts don't seem successful, possibly LD_PRELOAD should work

@mkg20001 mkg20001 force-pushed the mkg20001:pkg/bless branch from 9c43919 to 1c5e316 Dec 21, 2019
@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Dec 23, 2019

It's fixed, please re-review

@mkg20001 mkg20001 requested a review from jtojnar Dec 23, 2019
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

nixpkgs-review passes
executable works
NixOS unstable on x86_64

[3 built, 11 copied (332.9 MiB), 84.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75670
1 package built:
bless
@mkg20001 mkg20001 force-pushed the mkg20001:pkg/bless branch from 1c5e316 to 9564fbf Jan 25, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/88

@mkg20001 mkg20001 force-pushed the mkg20001:pkg/bless branch from 9564fbf to 72337be Feb 1, 2020
@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Feb 2, 2020

Applied review changes, should be good to merge now

@mkg20001
Copy link
Member Author

@mkg20001 mkg20001 commented Feb 2, 2020

/me begs for a merge

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 9, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/94

@worldofpeace worldofpeace merged commit 4ced561 into NixOS:master Feb 9, 2020
15 checks passed
15 checks passed
bless on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
bless on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.