Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuir: init at 1.28.03 #75817

Merged
merged 2 commits into from Jan 11, 2020
Merged

tuir: init at 1.28.03 #75817

merged 2 commits into from Jan 11, 2020

Conversation

@Br1ght0ne
Copy link
Contributor

@Br1ght0ne Br1ght0ne commented Dec 17, 2019

Motivation for this change

rtv is no longer maintained. tuir is one of the suggested alternatives, seems to be maintained and advancing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer @wedens

Feel free to let me know if you want to also maintain this package.


This change is Reviewable

@matthiasbeyer
Copy link
Contributor

@matthiasbeyer matthiasbeyer commented Dec 17, 2019

Sad to see rtv die. Is there a process to deprecate the package in nixpkgs?

Feel free to add me as maintainer!

@Br1ght0ne Br1ght0ne mentioned this pull request Dec 17, 2019
1 of 10 tasks complete
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Please rewrite the commit with my correct email address (see my profile).

@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:tuir-1.28.3 branch from 61b17b5 to 413b963 Dec 17, 2019
@wedens
Copy link

@wedens wedens commented Dec 17, 2019

@filalex77 Just curious, is there any particular reason you decided to go with tuir and not ttrv which seems to be another active rtv fork?

(I didn't know about any of them until now)

pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/tuir/default.nix Outdated Show resolved Hide resolved
Br1ght0ne and others added 2 commits Dec 17, 2019
Co-authored-by: Nikolay Korotkiy <sikmir@gmail.com>
Co-authored-by: Matthias Beyer <mail@beyermatthias.de>
@Br1ght0ne Br1ght0ne force-pushed the Br1ght0ne:tuir-1.28.3 branch from 413b963 to 687e31c Dec 30, 2019
@Br1ght0ne Br1ght0ne requested a review from sikmir Dec 30, 2019
@Br1ght0ne
Copy link
Contributor Author

@Br1ght0ne Br1ght0ne commented Dec 30, 2019

Thanks @sikmir!

@sikmir
sikmir approved these changes Dec 30, 2019
@aanderse aanderse merged commit 708a177 into NixOS:master Jan 11, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tuir on aarch64-linux Success
Details
tuir on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 12, 2020
tuir: init at 1.28.03
(cherry picked from commit 708a177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.