Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumpy, sambamba, and samblaster #75843

Merged
merged 3 commits into from Oct 15, 2020
Merged

Lumpy, sambamba, and samblaster #75843

merged 3 commits into from Oct 15, 2020

Conversation

@jbedo
Copy link
Contributor

@jbedo jbedo commented Dec 17, 2019

Motivation for this change

Add lumpy and prerequisites to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 23, 2020

Please put each package in a different PR, and format the PR title to match the commit message - use e.g newAttr: init at ....

@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Feb 23, 2020

Lumpy depends on sambamba and samblaster so it makes sense to have them in one PR as lumpy would be broken if by itself. I have done similar PRs in the past without issues, are you sure you want to split them?

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 25, 2020

On a 2nd thought, I guess it's OK :).

@jbedo jbedo force-pushed the lumpy branch 2 times, most recently from be169a7 to 0341ec4 Feb 26, 2020
@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Jul 2, 2020

Anything else I need to do to get this merged?

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jul 3, 2020

Now I see there's a CI error.

@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Jul 4, 2020

Weird, the hash changed. Fixed hash and rebased against latest master.

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 15, 2020

Result of nixpkgs-review pr 75843 1

3 packages built:
  • lumpy
  • sambamba
  • samblaster

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Oct 15, 2020

Sorry for the long wait and thanks for your contribution.

@doronbehar doronbehar merged commit 1db3202 into NixOS:master Oct 15, 2020
16 checks passed
16 checks passed
@ofborg[bot]
lumpy, lumpy.passthru.tests, sambamba, sambamba.passthru.tests, samblaster, samblaster.passthru.tests on aarch64-linux No attempt
Details
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a3d6e7b"; rev="a3d6e7b4b4585c5bc5bd8c7e6c8f305daecdd03b"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
lumpy, lumpy.passthru.tests, sambamba, sambamba.passthru.tests, samblaster, samblaster.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants