Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not depend on pangox_compat #75909

Merged
merged 5 commits into from Dec 20, 2019
Merged

Do not depend on pangox_compat #75909

merged 5 commits into from Dec 20, 2019

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 19, 2019

pango recently broke pangox_compat package but most packages do not actually need it – they were probably only adding it because gtkglext required it. We switched to master branch of gtkglext which fixes lot of issues and also no longer requires pangox.

package builds runs
gnome2.gtkglext ✔️ 🤷‍♀️
pcb ✔️ ✔️
k3d ✔️ ✔️
lutris ⌛️
desmume ✔️ ✔️
anydesk
openmodelica

anydesk seems to be an exception:

result/bin/anydesk: error while loading shared libraries: libpangox-1.0.so.0: cannot open shared object file: No such file or directory

but what can we expect from unfree software 😜️

openmodelica seems to fail for unrelated reasons:

checking LAPACK/BLAS flags... configure: error: dgesv (LAPACK) linking failed using -llapack -lblas
configure: error: ./configure failed for OMCompiler
builder for '/nix/store/2ivdliyd5f5r6xigz6j2z7id7bz9vsfw-openmodelica.drv' failed with exit code 1

Fixes: #75790

jtojnar added 5 commits Dec 18, 2019
Switched to HEAD to not depend on broken pangox-compat.
* Long overdue update
* Clean up the expression
* Drop unneeded pangox_compat – it was probably needed before gtkglext propagated it.
It was probably needed before gtkglext propagated it.
Drop unneeded pangox_compat – it was probably needed before gtkglext propagated it.

Also stop using aliases.
It was probably needed before gtkglext propagated it.
@jtojnar jtojnar requested a review from worldofpeace Dec 19, 2019
@ofborg ofborg bot requested review from AndersonTorres, 7c6f434c, mogorman and grwlf Dec 19, 2019
@jtojnar jtojnar force-pushed the jtojnar:gtkglext-fix branch from 1f7d4d9 to c3bc037 Dec 19, 2019
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 19, 2019

Hmmph, 😄 as usual I wish nothing needed pangox.

Copy link
Member

@worldofpeace worldofpeace left a comment

Looks great. I did not runtime test k3d, but everything else that was touched here.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 19, 2019

I think even trying to remove libpangox-1.0.so.0 with patchelf on anydesk might break it?
I'm not sure if it actually depended on it, or if this was just from gtkglext.

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM

[242 built (2 failed), 351 copied (3026.1 MiB), 673.8 MiB DL]
error: build of '/nix/store/203mf6w1mwgdvvdlp2cv1zksvcxn4wsk-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/75909
1 package are marked as broken and were skipped:
openmodelica

2 package failed to build:
anydesk gnash

8 package were built:
celestia desmume factor-lang gnome2.gtkglext k3d lutris lutris-free pcb
@jtojnar jtojnar merged commit 76c526a into NixOS:master Dec 20, 2019
16 checks passed
16 checks passed
desmume, gnome2.gtkglext, k3d, lutris, pcb on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
desmume, gnome2.gtkglext, k3d, lutris, pcb on aarch64-linux Success
Details
desmume, gnome2.gtkglext, k3d, lutris, pcb on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:gtkglext-fix branch Dec 20, 2019
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 23, 2020
Do not depend on pangox_compat

(cherry picked from commit 76c526a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.