Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: 4.0.3 -> 4.1.0 #75913

Closed
wants to merge 1 commit into from
Closed

platformio: 4.0.3 -> 4.1.0 #75913

wants to merge 1 commit into from

Conversation

@boxofrox
Copy link

@boxofrox boxofrox commented Dec 19, 2019

Motivation for this change

Upgrade PlatformIO package to latest release.

Only tested pio run and pio --version briefly on an existing project I started with platformio v4.0.3. Will start a new project this week to test more subcommands. CC'd others in case they want to test something of particular interest.

  • Install marshmallow 2.20.5 with internal package.
    PlatformIO is working on upgrading to marshmallow 3.x.
    Nixpkgs only supplies marshmallow 3.x.
  • Ignore tests/commands/test_check.py because it depends on internet access.
  • Add missing python dependencies for PlatformIO.
  • Fix schema tests by letting Nix download the SPDX license file.
  • Update patch for python search path.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mogorman @makefu @peterhoeg @dotlambda

@boxofrox
Copy link
Author

@boxofrox boxofrox commented Dec 19, 2019

Hmmm... what to do about CI error?

access to URI 'https://raw.githubusercontent.com/spdx/license-list-data/v3.6/json/licenses.json' is forbidden in restricted mode

I'm using builtins.fetchurl to retrieve the licenses.json. Possible alternatives:

  1. Download a copy of licenses.json into platformio package folder. I'm not a fan of bloating the repo with data files.
  2. Disable tests. I'd rather not disable tests if that can be avoided.
  3. Build an incomplete licenses.json from lib/licenses.nix. Not sure if this would contain sufficient info for the schema tests.
  4. Or maybe the CI just needs a trusted user to initiate the test?
- Install marshmallow 2.20.5 with internal package.  PlatformIO is
  working on upgrading to marshmallow 3.x.  Nixpkgs only supplies
  marshmallow 3.2.2.
- Ignore tests/commands/test_check.py because it depends on internet
  access.
- Add missing python dependencies for PlatformIO.
- Fix schema tests by letting Nix download the SPDX license file.
- Update patch for python search path.

Signed-off-by: Justin Charette <charetjc@gmail.com>
@boxofrox boxofrox force-pushed the boxofrox:u/pio4.1 branch from fe8adff to 2f525d6 Jan 1, 2020
@boxofrox
Copy link
Author

@boxofrox boxofrox commented Jan 2, 2020

Closing in favor of #76742

@boxofrox boxofrox closed this Jan 2, 2020
@boxofrox boxofrox mentioned this pull request Jan 2, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.