Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volctl: init at 0.6.2 #75949

Merged
merged 1 commit into from Dec 20, 2019
Merged

volctl: init at 0.6.2 #75949

merged 1 commit into from Dec 20, 2019

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Dec 19, 2019

Motivation for this change

Add volctl, a volume control for GNU/Linux desktops featuring per-app sliders.

It is a PulseAudio-enabled tray icon volume control for GNU/Linux desktops.

screenshot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@romildo
Copy link
Contributor Author

@romildo romildo commented Dec 19, 2019

I am not sure about making pavucontrol a dependency, because it is optional. The mixer can be set in the preferences dialog. But the source has a reference to /usr/bin/pavucontrol

Maybe changing it just to pavucontrol (without the directory) and expect that it can be found in $PATH would be a better solution.

@worldofpeace what do you think about this?

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 19, 2019

I am not sure about making pavucontrol a dependency, because it is optional. The mixer can be set in the preferences dialog. But the source has a reference to /usr/bin/pavucontrol

Maybe changing it just to pavucontrol (without the directory) and expect that it can be found in $PATH would be a better solution.

@worldofpeace what do you think about this?

I agree. Sometimes it's better left up to the environment when it's a gui application, and optional.

@teto
Copy link
Contributor

@teto teto commented Dec 20, 2019

nice app I was looking for ! Tested and it worked.

@romildo romildo force-pushed the romildo:upd.volctl branch from 32a7112 to 760e49e Dec 20, 2019
@romildo
Copy link
Contributor Author

@romildo romildo commented Dec 20, 2019

Removed the dependency on pavucontrol.

@teto teto merged commit 306c31a into NixOS:master Dec 20, 2019
16 checks passed
16 checks passed
volctl on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
volctl on aarch64-linux Success
Details
volctl on x86_64-linux Success
Details
@romildo romildo deleted the romildo:upd.volctl branch Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.