Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
services.xserver.imwheel: Fix default extraOptions #76054
Motivation for this change
related to #71052 it seems there was a mistake made during refactoring.
cc @Infinisil sorry that this sliped.
I think in cases like this (and especially for service that won't be that widely used probably) the consistency is the most important thing. So if this is standard for services in nixpkgs then I believe it's right thing to do. I was more just making excuse why I instinctively removed the escaping rather than changed the defaults. Thanks for the feedback
I think there is still valid argument that allowing this will teach folks to expect this format to work across services. Then in cases where service really does need to have arguments escaped they would shoot their foot expecting this format to work. I would rather guide towards single consistent behaviour apliable to all cases and avoid fragmentation of different behaviour which I belive is already a bit complicated to manage in nixpkgs.
TL;DR: after thinking about it I think I was wrong and you're right.