Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: fix cargoSha256 (again) #76060

Merged
merged 7 commits into from Dec 20, 2019
Merged

treewide: fix cargoSha256 (again) #76060

merged 7 commits into from Dec 20, 2019

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Dec 19, 2019

Motivation for this change

Previously: #62047

This time the change in cargo vendor output was caused by a4fc84d.

I hope that some time soon we can ban buildRustPackage from Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

alyssais added 3 commits Dec 19, 2019
cargo-vendor output was changed in a4fc84d.
cargo-vendor output was changed in a4fc84d.
cargo-vendor output was changed in a4fc84d.
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 19, 2019

carnix is worse at the moment due the large amounts of nix expressions it generates. There is no alternative atm.

@alyssais alyssais force-pushed the alyssais:cargo-vendor branch from d7363d6 to 5ac75b1 Dec 19, 2019
alyssais added 4 commits Dec 19, 2019
cargo-vendor output was changed in a4fc84d.
cargo-vendor output was changed in a4fc84d.
cargo-vendor output was changed in a4fc84d.
cargo-vendor output was changed in a4fc84d.
@alyssais alyssais force-pushed the alyssais:cargo-vendor branch from 5ac75b1 to 7c9b60e Dec 19, 2019
@ofborg ofborg bot requested review from tailhook, bennofs, valebes, globin, killercup, akru and gebner Dec 19, 2019
@alyssais alyssais merged commit 7887a81 into NixOS:master Dec 20, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
dua, elan, nix-index, polkadot, ripgrep, rsclock, webmetro on aarch64-linux Success
Details
dua, elan, nix-index, polkadot, ripgrep, rsclock, webmetro on x86_64-darwin Success
Details
dua, elan, nix-index, polkadot, ripgrep, rsclock, webmetro on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@alyssais alyssais deleted the alyssais:cargo-vendor branch Dec 20, 2019
@lilyball
Copy link
Member

@lilyball lilyball commented Dec 20, 2019

Why did the rustc update cause cargo vendor output to change though? What's the root cause here?

@lilyball
Copy link
Member

@lilyball lilyball commented Dec 20, 2019

I'm also curious why this change didn't affect all rust packages. For example, it doesn't look as though exa broke with the update.

@alyssais
Copy link
Member Author

@alyssais alyssais commented Dec 22, 2019

@lilyball
Copy link
Member

@lilyball lilyball commented Dec 22, 2019

Wow really? That seems really odd, because I thought Cargo.lock was intentionally and explicitly excluded from dependencies.

@alyssais
Copy link
Member Author

@alyssais alyssais commented Dec 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.