Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spago: 0.12.1.0 -> 0.13.0 #76084

Merged

Conversation

@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Dec 20, 2019

Motivation for this change

Update spago to the latest release:

https://github.com/spacchetti/spago/releases/tag/0.13.0

This requires that haskellPackages.dhall_1_27_0 exists, which was added in #76081 but hasn't been generated yet.

When it gets generated, this PR can be rebased on top of haskell-updates and merged in.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cdepillabout cdepillabout requested a review from basvandijk as a code owner Dec 20, 2019
@cdepillabout cdepillabout mentioned this pull request Dec 20, 2019
3 of 10 tasks complete
@peti peti force-pushed the NixOS:haskell-updates branch from 6484351 to 1f79abf Dec 20, 2019
@cdepillabout cdepillabout force-pushed the cdepillabout:update-spago-to-0.13.0 branch from 0c618cd to 00303de Dec 21, 2019
@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Dec 21, 2019

@GrahamcOfBorg build spago

@cdepillabout
Copy link
Member Author

@cdepillabout cdepillabout commented Dec 21, 2019

Looks like it is successful on x86_64. I'll go ahead and merge in.

It looks like it is failing on darwin for some reason, but I don't have a mac machine here to test on. Maybe someone will notice this and try to fix it up.

@cdepillabout cdepillabout merged commit 70b2584 into NixOS:haskell-updates Dec 21, 2019
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
spago on aarch64-linux
Details
spago on x86_64-darwin Failure
Details
spago on x86_64-linux Success
Details
@cdepillabout cdepillabout deleted the cdepillabout:update-spago-to-0.13.0 branch Dec 21, 2019
@simonchatts simonchatts mentioned this pull request Feb 18, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.