Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flyway: 6.1.0 -> 6.1.2 #76094

Merged
merged 2 commits into from Dec 20, 2019
Merged

flyway: 6.1.0 -> 6.1.2 #76094

merged 2 commits into from Dec 20, 2019

Conversation

@Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Dec 20, 2019

Motivation for this change

flyway: 6.1.0 -> 6.1.2
Fix for : jarDirs set by default to the proper location of share/flyway/jars
Related to #59687

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @CMCDragonkai

@Rakesh4G Rakesh4G force-pushed the formbay:flyway_fb branch from 1ba18e0 to ed1f16a Dec 20, 2019
@Rakesh4G
Copy link
Contributor Author

@Rakesh4G Rakesh4G commented Dec 20, 2019

Related to #59687

@ofborg ofborg bot requested a review from CMCDragonkai Dec 20, 2019
@Rakesh4G Rakesh4G force-pushed the formbay:flyway_fb branch from ed1f16a to 1d91ac4 Dec 20, 2019
@Rakesh4G Rakesh4G changed the title jarDirs set by default to the proper location of share/flyway/jars flyway: 6.1.0 -> 6.1.2 Dec 20, 2019
@teto teto merged commit be98fd4 into NixOS:master Dec 20, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
flyway on aarch64-linux Success
Details
flyway on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Rakesh4G Rakesh4G deleted the formbay:flyway_fb branch Dec 21, 2019
jerith666 added a commit to jerith666/nixpkgs that referenced this pull request Jan 2, 2020
this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main().  therefore, it must come after,
rather than before, the name of the main class.  (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to NixOS#76094
@jerith666 jerith666 mentioned this pull request Jan 2, 2020
4 of 10 tasks complete
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Feb 8, 2020
this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main().  therefore, it must come after,
rather than before, the name of the main class.  (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to NixOS#76094

(cherry picked from commit 2867d19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.