Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-lsp: Added 0.18.* to extra-packages for ghcide #76095

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@mgttlinger
Copy link
Contributor

@mgttlinger mgttlinger commented Dec 20, 2019

Motivation for this change

See #76087 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Dec 20, 2019

LGTM, thanks!

These packages should be available next time the hackage packages are regenerated (which usually happens once a day).

@cdepillabout cdepillabout merged commit 51b6345 into NixOS:haskell-updates Dec 20, 2019
1 check failed
1 check failed
grahamcofborg-eval The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked.
Details
@mgttlinger mgttlinger deleted the mgttlinger:haskell-lsp-0-18 branch Dec 20, 2019
@mgttlinger mgttlinger restored the mgttlinger:haskell-lsp-0-18 branch Jan 3, 2020
@mgttlinger mgttlinger deleted the mgttlinger:haskell-lsp-0-18 branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.