Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: 1.39 -> 1.40 #76100

Closed
wants to merge 1 commit into from
Closed

rustc: 1.39 -> 1.40 #76100

wants to merge 1 commit into from

Conversation

@edolstra
Copy link
Member

@edolstra edolstra commented Dec 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 20, 2019

Merge conflict due to documentation update.

@edolstra edolstra force-pushed the edolstra:rust-1.40 branch from 6271b84 to b5e8348 Dec 20, 2019
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 24, 2019

I am about to build fd on aarch64-linux and x86_64-linux.
We also need a macOS build. @alyssais @grahamc or @LnL7 could either of you run:

$ nix-review pr -p fd 76100

Our firefox/thunderbird build is still based on the old rustc version.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 24, 2019

fd on aarch64 builds!

@LnL7
LnL7 approved these changes Dec 24, 2019
Copy link
Member

@LnL7 LnL7 left a comment

Darwin build also looks good.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 24, 2019

fd on x86_64 builds!

@Mic92
Mic92 approved these changes Dec 24, 2019
@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Dec 24, 2019

pushed to staging: e82fae1

@Mic92 Mic92 closed this Dec 24, 2019
@oxalica oxalica mentioned this pull request Jan 2, 2020
5 of 10 tasks complete
@edolstra edolstra deleted the edolstra:rust-1.40 branch Jan 3, 2020
@nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 24, 2020

@edolstra @Mic92 why delete 1.39? I thought we started tracking multiple versions: #73039

@nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 24, 2020

or rather, why keep 1.38?

@edolstra
Copy link
Member Author

@edolstra edolstra commented Jan 24, 2020

We only keep old versions if there a specific need. 1.38 is (was?) needed for Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.