Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.nvim-lsp: init at 2019-12-17 #76109

Merged
merged 1 commit into from Dec 21, 2019
Merged

vimPlugins.nvim-lsp: init at 2019-12-17 #76109

merged 1 commit into from Dec 21, 2019

Conversation

@teto
Copy link
Contributor

@teto teto commented Dec 20, 2019

Motivation for this change

New out of the box neovim lsp implementation.
Works pretty well in my experience. Not as good as coc.nvim but pretty close and withtout the npm dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Contributor

@jonringer jonringer left a comment

LGTM

[3 built, 1 copied (32.4 MiB), 6.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76109
1 package were built:
vimPlugins.nvim-lsp
@jonringer jonringer merged commit bebfff6 into NixOS:master Dec 21, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.nvim-lsp on aarch64-linux Success
Details
vimPlugins.nvim-lsp on x86_64-darwin Success
Details
vimPlugins.nvim-lsp on x86_64-linux Success
Details
@timokau
Copy link
Member

@timokau timokau commented Dec 22, 2019

Doesn't this require a nightly neovim?

@teto
Copy link
Contributor Author

@teto teto commented Dec 22, 2019

yes it does; completely forgot about that: ther is some standard lua batteries included in nighlty neovim such as lsp/util.lua that are used in this plugin.

@teto teto deleted the teto:nvim_lsp branch Dec 22, 2019
@timokau
Copy link
Member

@timokau timokau commented Dec 23, 2019

In that case I think we should have waited for the neovim release before adding this plugin.

@ghost
Copy link

@ghost ghost commented Mar 4, 2020

This plugin will trigger a failure when used since its vimscript plugin will try to become a build system of its own, and 'install' things.

Error detected while processing /nix/store/v587bnyaydim9fal8l4p7s2v276lxbxn-vimplugin-nvim-lsp-3bcc387/share/vim-plugins/nvim-lsp/plugin/nvim_lsp.vim:
  line    9:
  E5108: Error executing lua Vim:E739: Cannot create directory /homeless-shelter: permission denied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.