Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtpass: Fix /usr/lib hardcode to pass-otp. #76113

Merged

Conversation

@nh2
Copy link
Contributor

@nh2 nh2 commented Dec 20, 2019

Motivation for this change

Before, the checkbox for OTP functionality could not be enabled on NixOS, even when (pass.withExtensions (exts: [ exts.pass-otp ])) was installed correctly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @hrdinka

@nh2 nh2 requested a review from hrdinka Dec 20, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Dec 20, 2019

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 21, 2019

You're missing the fetchpatch arg @nh2.

@nh2 nh2 force-pushed the nh2:qtpass-dont-hardcode-pass-otp-usr-lib branch from 20ebbb0 to a83fadc Dec 22, 2019
Before, the checkbox for OTP functionality could not be enabled on
NixOS, even when `(pass.withExtensions (exts: [ exts.pass-otp ]))`
was installed correctly.
@nh2 nh2 force-pushed the nh2:qtpass-dont-hardcode-pass-otp-usr-lib branch from a83fadc to 213e129 Dec 22, 2019
@nh2
Copy link
Contributor Author

@nh2 nh2 commented Dec 22, 2019

@worldofpeace worldofpeace merged commit 9f99517 into NixOS:master Dec 22, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qtpass on aarch64-linux Success
Details
qtpass on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.