Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xandikos: add tests and module #76178

Merged
merged 2 commits into from Jan 13, 2020
Merged

xandikos: add tests and module #76178

merged 2 commits into from Jan 13, 2020

Conversation

@0x4A6F
Copy link
Contributor

@0x4A6F 0x4A6F commented Dec 22, 2019

Motivation for this change

Add tests and module for xandikos, which is included in #75532.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

@0x4A6F
Copy link
Contributor Author

@0x4A6F 0x4A6F commented Dec 22, 2019

@GrahamcOfBorg test xandikos

1 similar comment
@Ma27
Copy link
Member

@Ma27 Ma27 commented Dec 22, 2019

@GrahamcOfBorg test xandikos

Copy link
Member

@Ma27 Ma27 left a comment

The change looks overall fine, thanks a lot!
Just a thought about the test: do we really need all of those VMs? I'm wondering as this means that you need notably more resources to execute the test-cases (although I'm not sure if we have some kind of "hard-limit" for tests, so feel free to disagree :D)

nixos/modules/services/networking/xandikos.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/xandikos.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/xandikos.nix Outdated Show resolved Hide resolved
@0x4A6F
Copy link
Contributor Author

@0x4A6F 0x4A6F commented Jan 8, 2020

I've reduced the vm-count on nixos test.
But at least I'd like to cover the main two use-cases (standalone and behind proxy).

If there is no more improvements, I'd like to rebase commits.

Thanks for the reviews.

Copy link
Contributor

@aanderse aanderse left a comment

LGTM 👍

@Ma27 @Infinisil any outstanding issues either of you see?

nixos/modules/services/networking/xandikos.nix Outdated Show resolved Hide resolved
0x4A6F added 2 commits Dec 14, 2019
@0x4A6F 0x4A6F force-pushed the 0x4A6F:master-xandikos branch from 7e2b821 to c9ca370 Jan 11, 2020
@Infinisil Infinisil changed the title xandikos: add tests and module Merge pull request #76178 from 0x4A6F/master-xandikos Jan 13, 2020
@Infinisil Infinisil merged commit 55b0129 into NixOS:master Jan 13, 2020
12 checks passed
12 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@0x4A6F 0x4A6F deleted the 0x4A6F:master-xandikos branch Jan 14, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
xandikos: add tests and module
(cherry picked from commit 55b0129)
@0x4A6F 0x4A6F changed the title Merge pull request #76178 from 0x4A6F/master-xandikos xandikos: add tests and module May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.