Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XP-PEN G430 Driver: init at 20190820 #76180

Closed
wants to merge 18 commits into from
Closed

Conversation

@IvarWithoutBones
Copy link
Contributor

IvarWithoutBones commented Dec 22, 2019

Motivation for this change

This driver is an useful application for people who own the XP-PEN G430 drawing tablet, as the tablet does not work without this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

I'm very sorry if i messed something up, fairly new to this.

@IvarWithoutBones IvarWithoutBones changed the title XP-PEN G460 Driver init at 20190820 XP-PEN G460 Driver: init at 20190820 Dec 22, 2019
@IvarWithoutBones IvarWithoutBones changed the title XP-PEN G460 Driver: init at 20190820 XP-PEN G430 Driver: init at 20190820 Dec 22, 2019
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/misc/drivers/xp-pen-g430/default.nix Outdated Show resolved Hide resolved
pkgs/misc/drivers/xp-pen-g430/default.nix Outdated Show resolved Hide resolved
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@IvarWithoutBones

This comment has been minimized.

Copy link
Contributor Author

IvarWithoutBones commented Mar 15, 2020

When trying to build locally with the change from qt5.qtbase > qtbase i get the following error:
error: anonymous function at /home/ivar/misc/nixpkgs/pkgs/misc/drivers/xp-pen-g430/default.nix:1:1 called without required argument 'qtbase', at /nix/store/lxid8qkmifw0bhyxa14qanvmkv5lkd5d-nixpkgs-20.09pre217039.13e7a3e1127/nixpkgs/lib/customisation.nix:69:16
Not sure how to fix

Copy link
Member

veprbl left a comment

Please test your PR

pkgs/misc/drivers/xp-pen-g430/default.nix Outdated Show resolved Hide resolved
pkgs/misc/drivers/xp-pen-g430/default.nix Outdated Show resolved Hide resolved
IvarWithoutBones and others added 4 commits Mar 21, 2020
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Copy link
Member

veprbl left a comment

Please squash all commits and rebase on top of master

pkgs/misc/drivers/xp-pen-g430/default.nix Outdated Show resolved Hide resolved
IvarWithoutBones and others added 2 commits Mar 23, 2020
Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@IvarWithoutBones

This comment has been minimized.

Copy link
Contributor Author

IvarWithoutBones commented Mar 23, 2020

Rebased, any chance you could just use the squash&merge feature from github? Im not that familiar with git, sorry ☹️

@Profpatsch

This comment has been minimized.

Copy link
Member

Profpatsch commented Mar 25, 2020

Let me take a look

@Profpatsch

This comment has been minimized.

Copy link
Member

Profpatsch commented Mar 25, 2020

I’m sorry, this PR is too broken to fix up. Could you manually take your current state and force-push it as one commit to this branch? Or open a new PR if you can’t figure out how to force-push (I admit, git can be a bit confusing).

Github has nice guides that give an introduction on how to use git with it’s interface, maybe you will want to read those.

As a general rule of thumb: don’t merge master back into your pull request branch, it makes changing things after the fact very hard.

@IvarWithoutBones

This comment has been minimized.

Copy link
Contributor Author

IvarWithoutBones commented Mar 26, 2020

Apologies for the trouble, will open up a new PR.

@IvarWithoutBones IvarWithoutBones mentioned this pull request Mar 26, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.