Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: 0.5.12 -> 0.5.15 #76276

Merged
merged 1 commit into from Jan 6, 2020
Merged

solc: 0.5.12 -> 0.5.15 #76276

merged 1 commit into from Jan 6, 2020

Conversation

@asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Dec 23, 2019

Motivation for this change
  • Update version.
  • Remove patchset for building shared library. See #39852 (comment) for a discussion.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru @lionello

@asymmetric asymmetric force-pushed the dapphub:solc-0.5.15 branch from 94be50b to 0a2e58f Dec 23, 2019
@ofborg ofborg bot requested review from akru, lionello and sifmelcara Dec 23, 2019
@asymmetric asymmetric force-pushed the dapphub:solc-0.5.15 branch from 0a2e58f to 45703d2 Dec 24, 2019
@livnev
Copy link
Contributor

@livnev livnev commented Dec 26, 2019

Tested on nixOS, it builds and works. 👍

@asymmetric
Copy link
Contributor Author

@asymmetric asymmetric commented Dec 26, 2019

@akru should we remove the dev output from

  outputs = [ "out" "dev" ];

?


EDIT: answered my own question.

Also removes patchset for shared library use, since usage of this
feature was rare and maintenance costly.
See #39852 (comment)
for a discussion.
@asymmetric asymmetric force-pushed the dapphub:solc-0.5.15 branch from 45703d2 to 4b45638 Dec 26, 2019
@asymmetric
Copy link
Contributor Author

@asymmetric asymmetric commented Jan 3, 2020

Is there still something to be done or can this be merged?

It introduces some changes that will be useful for future Linux versions (namely, removing a patch and building shared libraries)

@sifmelcara
Copy link
Contributor

@sifmelcara sifmelcara commented Jan 4, 2020

LGTM 👍, built on NixOS

@asymmetric asymmetric mentioned this pull request Jan 4, 2020
1 of 1 task complete
@domenkozar domenkozar merged commit 1101ef4 into NixOS:master Jan 6, 2020
15 checks passed
15 checks passed
solc on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
solc on x86_64-linux Success
Details
@asymmetric asymmetric deleted the dapphub:solc-0.5.15 branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.