Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-powerlevel10k: init at unstable-2019-12-19 #76386

Merged
merged 2 commits into from Jan 6, 2020
Merged

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 24, 2019

Motivation for this change

Powerlevel10k is a faster implementation of the popular powerlevel9k theme for zsh with fast git integration using gitstatusd, a custom implementation on top of it's own libgit2 fork. The latter two packages are already packaged and just needed bumping to work with the latest powerlevel10k theme.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmlb (gitstatus maintainer)
cc @flokli @andir @maralorn (p10k users)

@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Dec 24, 2019

Poked the upstream about doing releases. romkatv/powerlevel10k#392

@mmlb
Copy link
Contributor

@mmlb mmlb commented Dec 24, 2019

lgtm, but I don't have commit bits so we'll need to wait for someone else to checkout.

{ stdenv, fetchFromGitHub, substituteAll, pkgs }:

# To make use of this derivation, use
# `programs.zsh.promptInit = "source ${pkgs.zsh-powerlevel10k}/share/zsh-powerlevel10k/powerlevel10k.zsh-theme";`

This comment has been minimized.

@flokli

flokli Dec 24, 2019
Contributor

nixos/modules/programs/zsh/oh-my-zsh.nix sets programs.zsh.interactiveShellInit instead of programs.zsh.promptInit - I wonder what's the difference?

Also, what about adding a small NixOS module?

@flokli
Copy link
Contributor

@flokli flokli commented Dec 24, 2019

I tried to enable this as suggested in the comment, but I get a big fat warning gitstatusd failed to initialize:


  Your git prompt may disappear or become slow.

  Run the following command to retry with extra diagnostics:

    GITSTATUS_LOG_LEVEL=DEBUG gitstatus_start -s 1 -u 1 -d 1 -c 1 -m -1 -a POWERLEVEL9K

Unfortunately, when running that command, I don't get any output.

@flokli
Copy link
Contributor

@flokli flokli commented Dec 27, 2019

@mweinelt have you been able to reproduce this?

@mweinelt mweinelt force-pushed the mweinelt:powerlevel10k branch from 02d12ea to 68106d9 Jan 6, 2020
@mweinelt
Copy link
Member Author

@mweinelt mweinelt commented Jan 6, 2020

@flokli Yes, I have. It works like this for me, can you confirm?

Edit: Nope still broken.

@flokli
Copy link
Contributor

@flokli flokli commented Jan 6, 2020

Yes, now works for me too. Thanks for the fix!

@flokli flokli merged commit 15695df into NixOS:master Jan 6, 2020
@flokli
Copy link
Contributor

@flokli flokli commented Jan 6, 2020

If you find some time, still looking forward for a NixOS module option to trigger this :-)

@mweinelt mweinelt deleted the mweinelt:powerlevel10k branch Jan 7, 2020
@flokli flokli mentioned this pull request Jan 19, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.