Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

photoqt: use qt5's mkDerivation #76433

Merged
merged 1 commit into from Jan 8, 2020
Merged

Conversation

@valencik
Copy link
Contributor

@valencik valencik commented Dec 24, 2019

Motivation for this change

Prior to this PR photoqt would compile but fail on start with the following error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

zsh: abort (core dumped) result/bin/photoqt

I followed https://nixos.wiki/wiki/Qt and #65399 to fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

Copy link
Member

@worldofpeace worldofpeace left a comment

Can you use mkDerivation instead of stdenv.mkDerivation?
This is actually the qt specific deriver which automatically adds wrapQtAppsHook.

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Dec 24, 2019

I will backport this change to stable.

@valencik valencik force-pushed the valencik:photoqt-qtwrap branch from 4120277 to 399f57c Dec 26, 2019
@valencik
Copy link
Contributor Author

@valencik valencik commented Jan 3, 2020

@worldofpeace Could I get another review on this?
And is there anything I can do to help backport to stable?

@worldofpeace worldofpeace force-pushed the valencik:photoqt-qtwrap branch from 399f57c to 787a7f6 Jan 8, 2020
@worldofpeace worldofpeace changed the title Fix photoqt by adding wrapQtAppsHook photoqt: use qt5's mkDerivation Jan 8, 2020
@worldofpeace worldofpeace merged commit 09863a6 into NixOS:master Jan 8, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Cloning project
Details
@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Jan 8, 2020

@worldofpeace Could I get another review on this?
And is there anything I can do to help backport to stable?

Your pinged helped a lot 👍

I've merged your pull request, and I've backported the change to stable in

If you'd like to submit a backport pull request to nixpkgs, see the following documentation

In this case, it was necessary because the binaries could not execute properly at all on stable.

@valencik valencik deleted the valencik:photoqt-qtwrap branch Jan 8, 2020
@LouisTakePILLz LouisTakePILLz mentioned this pull request Apr 22, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.