Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Motivation for this change
I just updated the patch and mesa seems to build, but should this patch still be used?
It should be safe to remove that patch now, but you might want to verify that you're not hitting:
If the cache is being populated then it's fine. I had a look through all the drivers and they all seem to do sensible things now.
It should be fine to keep it. It's more conservative because it's keyed to the entire closure of Mesa, but less error prone because drivers don't have to explicitly query the build-id of dependencies like llvm.
We can drop it next time or whenever it stops trivially applying.