Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: 19.2.7 -> 19.3.1 #76496

Closed
wants to merge 1 commit into from
Closed

mesa: 19.2.7 -> 19.3.1 #76496

wants to merge 1 commit into from

Conversation

@Enzime
Copy link
Member

@Enzime Enzime commented Dec 25, 2019

Motivation for this change

https://www.mesa3d.org/relnotes/19.3.1.html

I just updated the patch and mesa seems to build, but should this patch still be used?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @corngood @vcunat @dtzWill

@Enzime Enzime changed the base branch from master to staging Dec 25, 2019
@Enzime
Copy link
Member Author

@Enzime Enzime commented Dec 25, 2019

@GrahamcOfBorg build mesa

@ofborg ofborg bot requested a review from vcunat Dec 25, 2019
@FRidh FRidh added this to WIP in Staging via automation Dec 30, 2019
@FRidh FRidh moved this from WIP to Needs review in Staging Dec 30, 2019
@Enzime
Copy link
Member Author

@Enzime Enzime commented Jan 4, 2020

@corngood can you confirm whether or not this patch is still necessary for Mesa 19.3.1?

@xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Jan 4, 2020

At first glance that appears to depend on the driver used: https://gitlab.freedesktop.org/mesa/mesa/commit/6a884014e46ab0ccca5c900f692898ffb02469e6

@corngood
Copy link
Contributor

@corngood corngood commented Jan 4, 2020

@Enzime

It should be safe to remove that patch now, but you might want to verify that you're not hitting:

   if (!st.st_mtime) {
      fprintf(stderr, "Mesa: The provided filesystem timestamp for the cache "
              "is bogus! Disabling On-disk cache.\n");
      return false;
   }

If the cache is being populated then it's fine. I had a look through all the drivers and they all seem to do sensible things now.

@vcunat
Copy link
Member

@vcunat vcunat commented Jan 4, 2020

Same mesa update was merged in #76892. The patch is still applied in there; I'm aware of no testing on our side so far, so I assume it's better to keep it until then?

@corngood
Copy link
Contributor

@corngood corngood commented Jan 4, 2020

It should be fine to keep it. It's more conservative because it's keyed to the entire closure of Mesa, but less error prone because drivers don't have to explicitly query the build-id of dependencies like llvm.

We can drop it next time or whenever it stops trivially applying.

@Enzime Enzime closed this Jan 5, 2020
Staging automation moved this from Needs review to Done Jan 5, 2020
@Enzime Enzime deleted the Enzime:update-mesa branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.