Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.graph-tool: 2.27 -> 2.29 #76506

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@SlothOfAnarchy
Copy link
Contributor

@SlothOfAnarchy SlothOfAnarchy commented Dec 25, 2019

The dependency 'pkg-config' was renamed and the two patches have since been
included or resolved.

Motivation for this change

I wanted to use features from a newer version. Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @joelmo @dasJ

@SlothOfAnarchy SlothOfAnarchy requested review from FRidh and jonringer as code owners Dec 25, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 25, 2019
@SlothOfAnarchy SlothOfAnarchy changed the title graph-tool: 2.27 -> 2.29 python3.pkgs.graph-tool: 2.27 -> 2.29 Dec 29, 2019
@dasJ
Copy link
Member

@dasJ dasJ commented Dec 29, 2019

Michel Weitbrecht
The dependency 'pkg-config' was renamed and the two patches have since been
included or resolved.
@SlothOfAnarchy SlothOfAnarchy force-pushed the helsinki-systems:upd/graph-tool branch from 2e809f7 to bf208c8 Dec 29, 2019
@dasJ
dasJ approved these changes Dec 29, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Dec 30, 2019

@GrahamcOfBorg build python3.pkgs.graph-tool

@dasJ
dasJ approved these changes Jan 1, 2020
@Lassulus Lassulus merged commit d38c463 into NixOS:master Jan 4, 2020
16 checks passed
16 checks passed
python3.pkgs.graph-tool on aarch64-linux Timed out, unknown build status
Details
python3.pkgs.graph-tool on x86_64-darwin Timed out, unknown build status
Details
python3.pkgs.graph-tool on x86_64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dasJ dasJ deleted the helsinki-systems:upd/graph-tool branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.