Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.gpxpy: init at 1.3.5 #76627

Merged
merged 1 commit into from Jan 12, 2020
Merged

python3Packages.gpxpy: init at 1.3.5 #76627

merged 1 commit into from Jan 12, 2020

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Dec 29, 2019

Motivation for this change

gpxpy - GPX file parser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh ./result
/nix/store/83z3y74jbf9n711ndvcp37fravn9h01m-gpxpy-1.3.5	 103.8M
Copy link
Contributor

@jonringer jonringer left a comment

please change commit message to:

python3Packages.gpxpy: init at 1.3.5

otherwise LGTM

@sikmir sikmir force-pushed the sikmir:gpxpy branch 2 times, most recently from b145577 to d00e412 Jan 12, 2020
@sikmir
Copy link
Member Author

@sikmir sikmir commented Jan 12, 2020

Done.

Copy link
Contributor

@jonringer jonringer left a comment

LGTM, beside 1 more change

https://github.com/NixOS/nixpkgs/pull/76627
3 package built:
python27Packages.gpxpy python37Packages.gpxpy python38Packages.gpxpy
pkgs/development/python-modules/gpxpy/default.nix Outdated Show resolved Hide resolved
@sikmir sikmir force-pushed the sikmir:gpxpy branch from d00e412 to d158dcb Jan 12, 2020
@jonringer jonringer changed the title gpxpy: init at 1.3.5 python3Packages.gpxpy: init at 1.3.5 Jan 12, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 12, 2020

@GrahamcOfBorg build python27Packages.gpxpy python37Packages.gpxpy python38Packages.gpxpy

@jonringer jonringer merged commit 9e9a105 into NixOS:master Jan 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.gpxpy, python37Packages.gpxpy, python38Packages.gpxpy on aarch64-linux Success
Details
python27Packages.gpxpy, python37Packages.gpxpy, python38Packages.gpxpy on x86_64-darwin Success
Details
python27Packages.gpxpy, python37Packages.gpxpy, python38Packages.gpxpy on x86_64-linux Success
Details
@sikmir sikmir deleted the sikmir:gpxpy branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.