Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many new pythonPackages #76631

Merged
merged 14 commits into from Jan 5, 2020
Merged

Add many new pythonPackages #76631

merged 14 commits into from Jan 5, 2020

Conversation

@kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Dec 29, 2019

  • Add many pythonPackages that exist on PyPi and not on nixpkgs
Motivation for this change
  • Nixpkgs completeness
Things done
  • Added myself as maintainer
  • Enforced Contributing guidelines on three existing packages (refactoring)
  • Added new packages at its current stable version
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
kamado:~/Documents/nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-509a25d2cbb870af19cd8646a21be1a7b060cee8-1/nixpkgs 3d70d4ba0b6be256974910e635fadcc0e9579b2a
Preparing worktree (detached HEAD 3d70d4ba0b6)
HEAD is now at 3d70d4ba0b6 nixos/displayManager: fix typo in legacy sessions (#76626)
$ nix-env -f /home/kamado/.cache/nix-review/rev-509a25d2cbb870af19cd8646a21be1a7b060cee8-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 509a25d2cbb870af19cd8646a21be1a7b060cee8
Updating 3d70d4ba0b6..509a25d2cbb
Fast-forward
 maintainers/maintainer-list.nix                                    | 10 ++++++++++
 pkgs/applications/misc/gcalcli/default.nix                         |  2 +-
 pkgs/applications/networking/gmailieer/default.nix                 |  2 +-
 pkgs/applications/networking/instant-messengers/blink/default.nix  |  2 +-
 pkgs/development/python-modules/alot/default.nix                   |  4 ++--
 pkgs/development/python-modules/azure-core/default.nix             | 35 +++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-identity/default.nix         | 43 +++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-keys/default.nix    | 39 +++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix   | 31 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-secrets/default.nix | 39 +++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/bandit/default.nix                 | 38 ++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/beancount/default.nix              |  8 ++++----
 pkgs/development/python-modules/eyed3/default.nix                  |  4 ++--
 pkgs/development/python-modules/gdrivefs/default.nix               |  4 ++--
 pkgs/development/python-modules/goobook/default.nix                |  4 ++--
 pkgs/development/python-modules/graphitepager/default.nix          |  4 ++--
 pkgs/development/python-modules/javaobj-py3/default.nix            | 25 ++++++++++++++++++++++++
 pkgs/development/python-modules/msal-extensions/default.nix        | 34 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/msal/default.nix                   | 34 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector-python/default.nix | 33 +++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector/default.nix        | 34 +++++++++++++-------------------
 pkgs/development/python-modules/names/default.nix                  | 25 ++++++++++++++++++++++++
 pkgs/development/python-modules/oyaml/default.nix                  | 32 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/peewee/default.nix                 |  4 ++--
 pkgs/development/python-modules/pushbullet/default.nix             |  4 ++--
 pkgs/development/python-modules/pydrive/default.nix                |  4 ++--
 pkgs/development/python-modules/pyjks/default.nix                  | 34 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/pysmb/default.nix                  | 34 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/relatorio/default.nix              |  4 ++--
 pkgs/development/python-modules/requirements-detector/default.nix  | 32 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/thumbor/default.nix                |  4 ++--
 pkgs/development/python-modules/twofish/default.nix                | 32 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/viewstate/default.nix              | 27 ++++++++++++++++++++++++++
 pkgs/development/python-modules/weboob/default.nix                 |  4 ++--
 pkgs/servers/home-assistant/component-packages.nix                 |  2 +-
 pkgs/servers/mautrix-telegram/default.nix                          |  2 +-
 pkgs/tools/misc/diffoscope/default.nix                             |  2 +-
 pkgs/tools/networking/s3cmd/default.nix                            |  4 ++--
 pkgs/top-level/python-packages.nix                                 | 47 +++++++++++++++++++++++++++++++++++++++------
 39 files changed, 665 insertions(+), 61 deletions(-)
 create mode 100644 pkgs/development/python-modules/azure-core/default.nix
 create mode 100644 pkgs/development/python-modules/azure-identity/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-keys/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-secrets/default.nix
 create mode 100644 pkgs/development/python-modules/bandit/default.nix
 create mode 100644 pkgs/development/python-modules/javaobj-py3/default.nix
 create mode 100644 pkgs/development/python-modules/msal-extensions/default.nix
 create mode 100644 pkgs/development/python-modules/msal/default.nix
 create mode 100644 pkgs/development/python-modules/mysql-connector-python/default.nix
 create mode 100644 pkgs/development/python-modules/names/default.nix
 create mode 100644 pkgs/development/python-modules/oyaml/default.nix
 create mode 100644 pkgs/development/python-modules/pyjks/default.nix
 create mode 100644 pkgs/development/python-modules/pysmb/default.nix
 create mode 100644 pkgs/development/python-modules/requirements-detector/default.nix
 create mode 100644 pkgs/development/python-modules/twofish/default.nix
 create mode 100644 pkgs/development/python-modules/viewstate/default.nix
$ nix-env -f /home/kamado/.cache/nix-review/rev-509a25d2cbb870af19cd8646a21be1a7b060cee8-1/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-509a25d2cbb870af19cd8646a21be1a7b060cee8-1/build.nix
55 package were built:
python27Packages.azure-core python27Packages.azure-identity python27Packages.azure-keyvault-keys python27Packages.azure-keyvault-nspkg python27Packages.azure-keyvault-secrets python27Packages.google-api-python-client python27Packages.javaobj-py3 python27Packages.msal python27Packages.msal-extensions python27Packages.mysql-connector python27Packages.mysql-connector-python python27Packages.names python27Packages.oyaml python27Packages.pyjks python27Packages.pysmb python27Packages.python-magic python27Packages.requirements-detector python27Packages.twofish python37Packages.azure-core python37Packages.azure-identity python37Packages.azure-keyvault-keys python37Packages.azure-keyvault-nspkg python37Packages.azure-keyvault-secrets python37Packages.bandit python37Packages.google-api-python-client python37Packages.javaobj-py3 python37Packages.msal python37Packages.msal-extensions python37Packages.mysql-connector python37Packages.mysql-connector-python python37Packages.names python37Packages.oyaml python37Packages.pyjks python37Packages.pysmb python37Packages.python-magic python37Packages.requirements-detector python37Packages.twofish python37Packages.viewstate python38Packages.azure-core python38Packages.azure-keyvault-nspkg python38Packages.bandit python38Packages.google-api-python-client python38Packages.javaobj-py3 python38Packages.msal python38Packages.msal-extensions python38Packages.mysql-connector python38Packages.mysql-connector-python python38Packages.names python38Packages.oyaml python38Packages.pyjks python38Packages.pysmb python38Packages.python-magic python38Packages.requirements-detector python38Packages.twofish python38Packages.viewstate

[0.0 MiB DL]
error: build log of '/nix/store/wg0k7wzh1s9vr10dknnzlnmm8i3fszgk-python2.7-google-api-python-client-1.7.6.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/qz88qv9498h1iw20in8gri11fx6aasw5-python2.7-python-magic-0.4.15.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/7mvq1n72ib4yd2c7r94rx1dgmxah37db-python3.7-google-api-python-client-1.7.11.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/vm78sav3drbblq7rfpd6a5c2m9mvpmgg-python3.7-python-magic-0.4.15.drv' is not available
[0.0 MiB DL]
[0.0 MiB DL]

logs are not found because those packages are not built, it's just a refactor

@tomberek
Copy link
Contributor

@tomberek tomberek commented Dec 29, 2019

Looks reasonable and with a consistent style. @FRidh or other python ecosystem owners should take a look.

Will these be update-able by r-ryantm?

Copy link
Contributor

@jonringer jonringer left a comment

I would move the canonical names commit into a different PR. It's diverged from adding many other python packages

@FRidh
Copy link
Member

@FRidh FRidh commented Dec 29, 2019

Do not pass in pythonPackages as argument to libraries in python-modules. Instead, define as parameters the individual dependencies.

@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages branch from 509a25d to bc69cd1 Dec 29, 2019
@kamadorueda
Copy link
Member Author

@kamadorueda kamadorueda commented Dec 29, 2019

@FRidh @jonringer sure, I just force-updated the PR with your suggestions

kamado:~/Documents/nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
From https://github.com/NixOS/nixpkgs
   3d70d4ba0b6..37e1da28748  master     -> refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f/nixpkgs 37e1da287483eac4a62597c73f31708389bfad19
Preparing worktree (detached HEAD 37e1da28748)
HEAD is now at 37e1da28748 ffmpeg: 3.4.6 -> 3.4.7 (security)
$ nix-env -f /home/kamado/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f
Updating 37e1da28748..bc69cd167bb
Fast-forward
 maintainers/maintainer-list.nix                                    | 10 +++++++++
 pkgs/development/python-modules/azure-core/default.nix             | 37 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-identity/default.nix         | 51 +++++++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-keys/default.nix    | 47 +++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix   | 33 +++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-secrets/default.nix | 47 +++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/bandit/default.nix                 | 42 +++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/javaobj-py3/default.nix            | 25 ++++++++++++++++++++++
 pkgs/development/python-modules/msal-extensions/default.nix        | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/msal/default.nix                   | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector-python/default.nix | 41 ++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector/default.nix        | 34 ++++++++++++------------------
 pkgs/development/python-modules/names/default.nix                  | 25 ++++++++++++++++++++++
 pkgs/development/python-modules/oyaml/default.nix                  | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/peewee/default.nix                 |  4 ++--
 pkgs/development/python-modules/pyjks/default.nix                  | 36 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/pysmb/default.nix                  | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/requirements-detector/default.nix  | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/twofish/default.nix                | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/viewstate/default.nix              | 27 ++++++++++++++++++++++++
 pkgs/tools/networking/s3cmd/default.nix                            |  2 +-
 pkgs/top-level/python-packages.nix                                 | 37 +++++++++++++++++++++++++++++++-
 22 files changed, 671 insertions(+), 25 deletions(-)
 create mode 100644 pkgs/development/python-modules/azure-core/default.nix
 create mode 100644 pkgs/development/python-modules/azure-identity/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-keys/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-secrets/default.nix
 create mode 100644 pkgs/development/python-modules/bandit/default.nix
 create mode 100644 pkgs/development/python-modules/javaobj-py3/default.nix
 create mode 100644 pkgs/development/python-modules/msal-extensions/default.nix
 create mode 100644 pkgs/development/python-modules/msal/default.nix
 create mode 100644 pkgs/development/python-modules/mysql-connector-python/default.nix
 create mode 100644 pkgs/development/python-modules/names/default.nix
 create mode 100644 pkgs/development/python-modules/oyaml/default.nix
 create mode 100644 pkgs/development/python-modules/pyjks/default.nix
 create mode 100644 pkgs/development/python-modules/pysmb/default.nix
 create mode 100644 pkgs/development/python-modules/requirements-detector/default.nix
 create mode 100644 pkgs/development/python-modules/twofish/default.nix
 create mode 100644 pkgs/development/python-modules/viewstate/default.nix
$ nix-env -f /home/kamado/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f/build.nix
[1 built, 0.0 MiB DL]
49 package were built:
python27Packages.azure-core python27Packages.azure-identity python27Packages.azure-keyvault-keys python27Packages.azure-keyvault-nspkg python27Packages.azure-keyvault-secrets python27Packages.javaobj-py3 python27Packages.msal python27Packages.msal-extensions python27Packages.mysql-connector python27Packages.mysql-connector-python python27Packages.names python27Packages.oyaml python27Packages.pyjks python27Packages.pysmb python27Packages.requirements-detector python27Packages.twofish python37Packages.azure-core python37Packages.azure-identity python37Packages.azure-keyvault-keys python37Packages.azure-keyvault-nspkg python37Packages.azure-keyvault-secrets python37Packages.bandit python37Packages.javaobj-py3 python37Packages.msal python37Packages.msal-extensions python37Packages.mysql-connector python37Packages.mysql-connector-python python37Packages.names python37Packages.oyaml python37Packages.pyjks python37Packages.pysmb python37Packages.requirements-detector python37Packages.twofish python37Packages.viewstate python38Packages.azure-core python38Packages.azure-keyvault-nspkg python38Packages.bandit python38Packages.javaobj-py3 python38Packages.msal python38Packages.msal-extensions python38Packages.mysql-connector python38Packages.mysql-connector-python python38Packages.names python38Packages.oyaml python38Packages.pyjks python38Packages.pysmb python38Packages.requirements-detector python38Packages.twofish python38Packages.viewstate

$ nix-shell /home/kamado/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f/shell.nix
innovation

[nix-shell:~/.cache/nix-review/rev-bc69cd167bb3d1a3e2a97f6ff15c82b7a5241e8f]$ exit
$ git worktree prune
kamado:~/Documents/nixpkgs$
@kamadorueda kamadorueda requested a review from jonringer Dec 29, 2019
@jonringer
Copy link
Contributor

@jonringer jonringer commented Dec 29, 2019

a few of these packages I added as part of #76059 going to hold off on this PR for a little bit

@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages branch from bc69cd1 to 586ea2b Dec 31, 2019
@FRidh
Copy link
Member

@FRidh FRidh commented Jan 3, 2020

rebase is needed.

@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages branch from 586ea2b to 95c2389 Jan 3, 2020
@kamadorueda
Copy link
Member Author

@kamadorueda kamadorueda commented Jan 3, 2020

@FRidh just rebased

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
From https://github.com/NixOS/nixpkgs
   5aed91512da..4f6f0491a4d  master     -> refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770/nixpkgs 4f6f0491a4d8d4350b814c0f06198cbace995320
Preparing worktree (detached HEAD 4f6f0491a4d)
HEAD is now at 4f6f0491a4d Merge pull request #76854 from earksiinni/ersin/prl-tools-no-assert-version
$ nix-env -f /home/kamado/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 95c2389b69efed5beac9f55d2c75c7b8b418f770
Updating 4f6f0491a4d..95c2389b69e
Fast-forward
 maintainers/maintainer-list.nix                                    | 10 +++++++++
 pkgs/development/python-modules/azure-identity/default.nix         | 51 +++++++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix   | 33 +++++++++++++++++++++++++++++
 pkgs/development/python-modules/bandit/default.nix                 | 42 +++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/javaobj-py3/default.nix            | 25 ++++++++++++++++++++++
 pkgs/development/python-modules/msal-extensions/default.nix        | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/msal/default.nix                   | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector-python/default.nix | 41 ++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/mysql-connector/default.nix        | 34 ++++++++++++------------------
 pkgs/development/python-modules/names/default.nix                  | 25 ++++++++++++++++++++++
 pkgs/development/python-modules/oyaml/default.nix                  | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/peewee/default.nix                 |  4 ++--
 pkgs/development/python-modules/pyjks/default.nix                  | 36 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/pysmb/default.nix                  | 34 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/requirements-detector/default.nix  | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/twofish/default.nix                | 32 ++++++++++++++++++++++++++++
 pkgs/development/python-modules/viewstate/default.nix              | 27 ++++++++++++++++++++++++
 pkgs/tools/networking/s3cmd/default.nix                            |  2 +-
 pkgs/top-level/python-packages.nix                                 | 33 +++++++++++++++++++++++++++--
 19 files changed, 535 insertions(+), 26 deletions(-)
 create mode 100644 pkgs/development/python-modules/azure-identity/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix
 create mode 100644 pkgs/development/python-modules/bandit/default.nix
 create mode 100644 pkgs/development/python-modules/javaobj-py3/default.nix
 create mode 100644 pkgs/development/python-modules/msal-extensions/default.nix
 create mode 100644 pkgs/development/python-modules/msal/default.nix
 create mode 100644 pkgs/development/python-modules/mysql-connector-python/default.nix
 create mode 100644 pkgs/development/python-modules/names/default.nix
 create mode 100644 pkgs/development/python-modules/oyaml/default.nix
 create mode 100644 pkgs/development/python-modules/pyjks/default.nix
 create mode 100644 pkgs/development/python-modules/pysmb/default.nix
 create mode 100644 pkgs/development/python-modules/requirements-detector/default.nix
 create mode 100644 pkgs/development/python-modules/twofish/default.nix
 create mode 100644 pkgs/development/python-modules/viewstate/default.nix
$ nix-env -f /home/kamado/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770/build.nix
[56 built, 277 copied (766.8 MiB), 166.3 MiB DL]
41 package were built:
python27Packages.azure-keyvault-nspkg python27Packages.javaobj-py3 python27Packages.msal python27Packages.msal-extensions python27Packages.mysql-connector python27Packages.mysql-connector-python python27Packages.names python27Packages.oyaml python27Packages.pyjks python27Packages.pysmb python27Packages.requirements-detector python27Packages.twofish python37Packages.azure-identity python37Packages.azure-keyvault-nspkg python37Packages.bandit python37Packages.javaobj-py3 python37Packages.msal python37Packages.msal-extensions python37Packages.mysql-connector python37Packages.mysql-connector-python python37Packages.names python37Packages.oyaml python37Packages.pyjks python37Packages.pysmb python37Packages.requirements-detector python37Packages.twofish python37Packages.viewstate python38Packages.azure-keyvault-nspkg python38Packages.bandit python38Packages.javaobj-py3 python38Packages.msal python38Packages.msal-extensions python38Packages.mysql-connector python38Packages.mysql-connector-python python38Packages.names python38Packages.oyaml python38Packages.pyjks python38Packages.pysmb python38Packages.requirements-detector python38Packages.twofish python38Packages.viewstate

$ nix-shell /home/kamado/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770/shell.nix
these paths will be fetched (1.51 MiB download, 8.27 MiB unpacked):
  /nix/store/457laddwhi2pxrj75l2633b2847j25y2-bash-interactive-4.4-p23-man
  /nix/store/gphsplca5qadv83i3dm93mi9ycrxsipq-bash-interactive-4.4-p23
  /nix/store/n48g3r6h6gjigq4zv4gsa9vzn2hcbfxn-bash-interactive-4.4-p23-doc
  /nix/store/qz1kiqjbwvlyskrbq6ka5d0wij4xx09a-readline-7.0p5
  /nix/store/szwz90jhw59jf2lvpmakb1n32mh1vvsb-bash-interactive-4.4-p23-dev
  /nix/store/wwzj1xb7i7wvhkxnl3gg5253yl9rdlgb-bash-interactive-4.4-p23-info
copying path '/nix/store/n48g3r6h6gjigq4zv4gsa9vzn2hcbfxn-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/457laddwhi2pxrj75l2633b2847j25y2-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/wwzj1xb7i7wvhkxnl3gg5253yl9rdlgb-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/qz1kiqjbwvlyskrbq6ka5d0wij4xx09a-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/gphsplca5qadv83i3dm93mi9ycrxsipq-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/szwz90jhw59jf2lvpmakb1n32mh1vvsb-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
innovation

[nix-shell:~/.cache/nix-review/rev-95c2389b69efed5beac9f55d2c75c7b8b418f770]$ exit
$ git worktree prune
kamado:~/Documents/nixpkgs$
@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages branch from 95c2389 to f335b27 Jan 3, 2020
msrestazure
];

doCheck = false;

This comment has been minimized.

@FRidh

FRidh Jan 3, 2020
Member

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled. Please do this with all packages.

This comment has been minimized.

@kamadorueda

kamadorueda Jan 3, 2020
Author Member

comments have been added above the doCheck = false;s in the latest forced-push

I also added tests to the packages in which doing so is possible

kamado:~/Documents/nixpkgs$ nix-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
From https://github.com/NixOS/nixpkgs
   4f6f0491a4d..0b7b588de24  master     -> refs/nix-review/0
$ git worktree add /home/kamado/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3/nixpkgs 0b7b588de246397b6c5e717e68e7015e7a9a0766
Preparing worktree (detached HEAD 0b7b588de24)
Updating files: 100% (20628/20628), done.
HEAD is now at 0b7b588de24 Merge pull request #76904 from ivan/ivan-unmaintain
$ nix-env -f /home/kamado/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit ff892ee1f063b4696a6a94983e0e986509e3cbf3
Updating 0b7b588de24..ff892ee1f06
Fast-forward
 maintainers/maintainer-list.nix                                   | 10 +++++++++
 pkgs/development/python-modules/azure-identity/default.nix        | 53 ++++++++++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix  | 35 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/bandit/default.nix                | 44 ++++++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/javaobj-py3/default.nix           | 26 +++++++++++++++++++++++
 pkgs/development/python-modules/msal-extensions/default.nix       | 35 ++++++++++++++++++++++++++++++
 pkgs/development/python-modules/msal/default.nix                  | 36 +++++++++++++++++++++++++++++++
 pkgs/development/python-modules/names/default.nix                 | 36 +++++++++++++++++++++++++++++++
 pkgs/development/python-modules/oyaml/default.nix                 | 41 +++++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/pyjks/default.nix                 | 37 ++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/pysmb/default.nix                 | 36 +++++++++++++++++++++++++++++++
 pkgs/development/python-modules/requirements-detector/default.nix | 38 +++++++++++++++++++++++++++++++++
 pkgs/development/python-modules/twofish/default.nix               | 33 +++++++++++++++++++++++++++++
 pkgs/development/python-modules/viewstate/default.nix             | 36 +++++++++++++++++++++++++++++++
 pkgs/top-level/python-packages.nix                                | 31 +++++++++++++++++++++++++--
 15 files changed, 525 insertions(+), 2 deletions(-)
 create mode 100644 pkgs/development/python-modules/azure-identity/default.nix
 create mode 100644 pkgs/development/python-modules/azure-keyvault-nspkg/default.nix
 create mode 100644 pkgs/development/python-modules/bandit/default.nix
 create mode 100644 pkgs/development/python-modules/javaobj-py3/default.nix
 create mode 100644 pkgs/development/python-modules/msal-extensions/default.nix
 create mode 100644 pkgs/development/python-modules/msal/default.nix
 create mode 100644 pkgs/development/python-modules/names/default.nix
 create mode 100644 pkgs/development/python-modules/oyaml/default.nix
 create mode 100644 pkgs/development/python-modules/pyjks/default.nix
 create mode 100644 pkgs/development/python-modules/pysmb/default.nix
 create mode 100644 pkgs/development/python-modules/requirements-detector/default.nix
 create mode 100644 pkgs/development/python-modules/twofish/default.nix
 create mode 100644 pkgs/development/python-modules/viewstate/default.nix
$ nix-env -f /home/kamado/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/kamado/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3/build.nix
[1 built, 0.0 MiB DL]
34 package were built:
python27Packages.azure-keyvault-nspkg python27Packages.javaobj-py3 python27Packages.msal python27Packages.msal-extensions python27Packages.names python27Packages.oyaml python27Packages.pyjks python27Packages.pysmb python27Packages.twofish python37Packages.azure-identity python37Packages.azure-keyvault-nspkg python37Packages.bandit python37Packages.javaobj-py3 python37Packages.msal python37Packages.msal-extensions python37Packages.names python37Packages.oyaml python37Packages.pyjks python37Packages.pysmb python37Packages.requirements-detector python37Packages.twofish python37Packages.viewstate python38Packages.azure-keyvault-nspkg python38Packages.bandit python38Packages.javaobj-py3 python38Packages.msal python38Packages.msal-extensions python38Packages.names python38Packages.oyaml python38Packages.pyjks python38Packages.pysmb python38Packages.requirements-detector python38Packages.twofish python38Packages.viewstate

$ nix-shell /home/kamado/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3/shell.nix
innovation

[nix-shell:~/.cache/nix-review/rev-ff892ee1f063b4696a6a94983e0e986509e3cbf3]$ 
kamadorueda added 7 commits Dec 28, 2019
kamadorueda added 7 commits Dec 28, 2019
@kamadorueda kamadorueda force-pushed the kamadorueda:pythonPackages branch from f335b27 to ff892ee Jan 3, 2020
@kamadorueda kamadorueda requested a review from FRidh Jan 4, 2020
@FRidh FRidh merged commit 0d0a4f1 into NixOS:master Jan 5, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.