Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus-table-vietnamese: init at 20190825 #76632

Closed
wants to merge 1 commit into from
Closed

Conversation

@McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Dec 29, 2019

Motivation for this change

I am trying to add some Vietnamese IBus tables I have been using on regular basis for quite a few year. This is the first time I am doing this so I am not sure if there is anything missing.

Additionally, is setting $HOME to a temporary directory before build necessary in this case? This is almost a copypasta from the ibus-table-others which does it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (nix-build -A ibus-engines.table-vietnamese)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@McSinyx
Copy link
Contributor Author

@McSinyx McSinyx commented Jan 9, 2020

Since this is merged to ibus-table-others, I'm closing this PR.

@McSinyx McSinyx closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.