Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pynagsystemd: init at 1.2.0 and dependencies #76641

Merged
merged 2 commits into from Jan 3, 2020

Conversation

@symphorien
Copy link
Contributor

@symphorien symphorien commented Dec 29, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@symphorien symphorien requested review from FRidh and jonringer as code owners Dec 29, 2019
sha256 = "1vr3zy0zfvbrqc4nf81zxv4gs2q82sv5sjamdm4573ld529mk2nv";
};

buildInputs = [ twine ];

This comment has been minimized.

@FRidh

FRidh Dec 29, 2019
Member

How is twine used? We basically never add Python modules as buildInputs.

This comment has been minimized.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 3, 2020

please squash the commits into the related package commit

Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@symphorien symphorien force-pushed the symphorien:pynagsystemd branch from 4cd9bef to d22164b Jan 3, 2020
@symphorien
Copy link
Contributor Author

@symphorien symphorien commented Jan 3, 2020

done

Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

[6 built, 113 copied (514.2 MiB), 118.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76641
3 package were built:
pynagsystemd python37Packages.nagiosplugin python38Packages.nagiosplugin
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 3, 2020

@GrahamcOfBorg build pynagsystemd python37Packages.nagiosplugin python38Packages.nagiosplugin

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 3, 2020

arm failures unrelated to PR

@jonringer jonringer merged commit b40fc3a into NixOS:master Jan 3, 2020
18 checks passed
18 checks passed
pynagsystemd on aarch64-linux Failure
Details
pynagsystemd, python37Packages.nagiosplugin, python38Packages.nagiosplugin on aarch64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pynagsystemd on x86_64-linux Success
Details
pynagsystemd, python37Packages.nagiosplugin, python38Packages.nagiosplugin on x86_64-darwin Success
Details
pynagsystemd, python37Packages.nagiosplugin, python38Packages.nagiosplugin on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.