Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bemenu: 0.1.0 -> 0.3.0 #76676

Merged
merged 1 commit into from Jan 1, 2020
Merged

Bemenu: 0.1.0 -> 0.3.0 #76676

merged 1 commit into from Jan 1, 2020

Conversation

@NilsIrl
Copy link
Contributor

@NilsIrl NilsIrl commented Dec 30, 2019

Motivation for this change

New bemenu version.

Things done

Bump version. Use rec to not hard code commit.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all only wayland and ncurses support. X11 didn't work for me binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thiagokokada

Copy link
Contributor

@thiagokokada thiagokokada left a comment

👍

I tested on all three backends (including x11).

Btw, I am not using this package anymore so if you want to adopt @NilsIrl, you're welcome, since it seems there is still some issues with this package like you reported here: #60661 (comment)

@NilsIrl
Copy link
Contributor Author

@NilsIrl NilsIrl commented Dec 30, 2019

there is still some issues with this package like you reported here: #60661 (comment)

For some reason I wasn't able to reproduce that. Might have had to do with fonts.enableDefaultFonts though that shouldn't have been a problem as programs.sway.enable was set to true.

@NilsIrl
Copy link
Contributor Author

@NilsIrl NilsIrl commented Dec 30, 2019

so if you want to adopt @NilsIrl, you're welcome

It would be an honor, however, I have very limited knowledge of nix and bemenu so I don't think I would be the most capable for this.

Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Other than a few nitpicks, LGTM.

[3 built, 69 copied (526.5 MiB), 118.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76676
1 package built:
bemenu
pkgs/applications/misc/bemenu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/bemenu/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

LGTM.

To maintainers: please squash commits before merging.

@ofborg ofborg bot requested a review from thiagokokada Dec 30, 2019
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Jan 1, 2020

I'd appreciate for PR authors to squash the commits themselves because:

  • If the change doesn't make sense as a single commit, the GitHub squash button can't be used
  • It maintains the original SHA1 and signature of the PR author
  • It requires people to learn how to interactively git rebase and how to name their commits
@NilsIrl NilsIrl force-pushed the NilsIrl:bemenu0.3 branch 3 times, most recently from 0a27b34 to 4b126eb Jan 1, 2020
Add option to enable backends.

Co-Authored-By: Oleksii Filonenko <brightone@protonmail.com>
@NilsIrl NilsIrl force-pushed the NilsIrl:bemenu0.3 branch from 4b126eb to b20fbee Jan 1, 2020
@NilsIrl
Copy link
Contributor Author

@NilsIrl NilsIrl commented Jan 1, 2020

Ok, rebased it. Only took me 4 tries to get @filalex77 to be recognised as co-author (I wasn't sure where to put the line in the commit message)

@Infinisil Infinisil merged commit 286450b into NixOS:master Jan 1, 2020
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Beginning Evaluations
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@NilsIrl NilsIrl deleted the NilsIrl:bemenu0.3 branch Jan 1, 2020
@ofborg ofborg bot requested a review from thiagokokada Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.