Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbass: 2.4.14 -> 2.4.15 #76692

wants to merge 1 commit into from

libbass: 2.4.14 -> 2.4.15 #76692

wants to merge 1 commit into from


Copy link

iimog commented Dec 30, 2019

Motivation for this change

libbass was updated to 2.4.15 on December 17, 2019. As documented in the source comment this breaks the package as the download file is replaced in-place and the hash sum changes (of course). It also breaks the packages ultrastar-manager and ultrastar-creator that depend on libbass.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @abbradar

Copy link

ehmry commented May 4, 2020

Updated at a5bf5e2, I should have merged this first.

@ehmry ehmry closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.