Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schismtracker: 20120105 -> 20190805 #76725

Merged
merged 1 commit into from May 2, 2020
Merged

Conversation

@OPNA2608
Copy link
Contributor

OPNA2608 commented Dec 31, 2019

Motivation for this change

Schismtracker was severely out of date. (not touched since it was added)

Things done

Updated version, switched to GitHub repository and dropped obsolete workaround.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    (72814208 -> 73078200)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ftrvxmtrx

@OPNA2608 OPNA2608 mentioned this pull request Mar 5, 2020
9 of 46 tasks complete
@OPNA2608 OPNA2608 force-pushed the OPNA2608:update-schismtracker branch from 7301a12 to 6ba6b8d Apr 14, 2020
@ofborg ofborg bot requested a review from ftrvxmtrx Apr 14, 2020
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Apr 14, 2020

Resolved merge conflict.

@veprbl
veprbl approved these changes May 1, 2020
@veprbl veprbl merged commit d6fcf36 into NixOS:master May 2, 2020
16 checks passed
16 checks passed
schismtracker, schismtracker.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6ba6b8d"; rev="6ba6b8d3eb66b3791254d012b521214d3bc89fbb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
schismtracker, schismtracker.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.