Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.scipy: 1.3.3 -> 1.4.1 enable tests use github src #76755

Closed
wants to merge 2 commits into from

Conversation

@costrouc
Copy link
Contributor

@costrouc costrouc commented Dec 31, 2019

Motivation for this change

This will be moved to staging-next. Wanted to make scipy tests enabled and use github src. This will enable testing scipy master easily against all dependant packages (something valuable to the python community). Sill a work in progress.

Since scipy 1.4.0 it requires pybind11 for the build. pybind11 uses scipy for tests. So scipy was removed from pybind11 dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

…ndency)
@costrouc costrouc requested review from FRidh and jonringer as code owners Dec 31, 2019
@ofborg ofborg bot added the 6.topic: python label Dec 31, 2019
@costrouc costrouc force-pushed the costrouc:python-scipy-tests branch 4 times, most recently from 568812f to 76c8487 Dec 31, 2019
@costrouc costrouc force-pushed the costrouc:python-scipy-tests branch from 76c8487 to 2deef15 Dec 31, 2019
@@ -35,11 +52,9 @@ buildPythonPackage rec {
enableParallelBuilding = true;

checkPhase = ''
runHook preCheck

This comment has been minimized.

@veprbl

veprbl Dec 31, 2019
Member

This silently breaks preCheck and postCheck for users trying to use overrides.

This comment has been minimized.

@costrouc

costrouc Jan 1, 2020
Author Contributor

Yeah so question about this. Isn't this just the way it has always been done for ALL python packages (I never see people adding precheck and postcheck for python packages)? I looked at the git blame and those lines were written 6 years ago.

This comment has been minimized.

@veprbl

veprbl Jan 1, 2020
Member

I don't know the answer to your question. However, I did check that this breaks hooks even for python packages.

@@ -55,7 +54,7 @@ buildPythonPackage rec {
checkInputs = [
pytest
numpy
scipy
# scipy not included due to recursive dependency

This comment has been minimized.

@veprbl

veprbl Dec 31, 2019
Member

Perhaps this could work:

Suggested change
# scipy not included due to recursive dependency
(scipy.override { pybind11 = null; })
src = fetchPypi {
inherit pname version;
sha256 = "64bf4e8ae0db2d42b58477817f648d81e77f0b381d0ea4427385bba3f959380a";
src = fetchFromGitHub {

This comment has been minimized.

@veprbl

veprbl Jan 1, 2020
Member

This breaks eval for python2Packages.scipy:

src = oldAttrs.src.override {
inherit version;
sha256 = "a4331e0b8dab1ff75d2c67b5158a8bb9a83c799d7140094dda936d876c7cfbb1";
};

@FRidh
Copy link
Member

@FRidh FRidh commented Jan 1, 2020

This is already in staging-next

@FRidh FRidh closed this Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.