Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_9: 9.0.0 -> 9.0.1 #76771

Merged
merged 2 commits into from Jan 3, 2020
Merged

llvm_9: 9.0.0 -> 9.0.1 #76771

merged 2 commits into from Jan 3, 2020

Conversation

@dtzWill
Copy link
Contributor

@dtzWill dtzWill commented Jan 1, 2020

Motivation for this change

Help testing any packages depending on llvm9 in-tree appreciated,
as well as checking various platforms and patch files are still
valid and appropriate/desired.

Things done

(Testing still underway, feedback / assistance appreciated/requested :))

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer
cc @LnL7

dtzWill added 2 commits Dec 31, 2019
Fetch from github release page,
as that's where https://releases.llvm.org/9.0.1 redirects.
@dtzWill dtzWill force-pushed the dtzWill:update/llvm-9.0.1 branch from 18696c2 to dc0c28a Jan 1, 2020
@dtzWill dtzWill changed the base branch from master to staging Jan 1, 2020
@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Jan 2, 2020

@GrahamcOfBorg build llvmPacages_9
@GrahamcOfBorg build pkgsMusl.llvmPackages_9
@GrahamcOfBorg build tests.cc-wrapper-clang-9 tests.cc-wrapper-libcxx-9
@GrahamcOfBorg build pkgsMusl.tests.cc-wrapper-clang-9 pkgsMusl.tests.cc-wrapper-libcxx-9

@dtzWill
Copy link
Contributor Author

@dtzWill dtzWill commented Jan 2, 2020

Whoops, musl cc-wrapper tests "fail" since the test attempts to use <sanitizer/asan_interface.h>. This failure is pre-existing.

Staging automation moved this from WIP to Ready Jan 3, 2020
@LnL7
LnL7 approved these changes Jan 3, 2020
Copy link
Member

@LnL7 LnL7 left a comment

LGTM and should supersede #74731

@LnL7 LnL7 merged commit dd5fd3b into NixOS:staging Jan 3, 2020
28 checks passed
28 checks passed
clang_9 on x86_64-darwin Timed out, unknown build status
Details
llvmPacages_9 on aarch64-linux No attempt
Details
llvmPacages_9 on x86_64-darwin No attempt
Details
llvmPacages_9 on x86_64-linux No attempt
Details
pkgsMusl.llvmPackages_9 on aarch64-linux Failure
Details
pkgsMusl.llvmPackages_9 on x86_64-darwin No attempt
Details
pkgsMusl.llvmPackages_9 on x86_64-linux Failure
Details
pkgsMusl.tests.cc-wrapper-clang-9, pkgsMusl.tests.cc-wrapper-libcxx-9 on aarch64-linux Failure
Details
pkgsMusl.tests.cc-wrapper-clang-9, pkgsMusl.tests.cc-wrapper-libcxx-9 on x86_64-darwin No attempt
Details
pkgsMusl.tests.cc-wrapper-clang-9, pkgsMusl.tests.cc-wrapper-libcxx-9 on x86_64-linux Failure
Details
tests.cc-wrapper-clang-9, tests.cc-wrapper-libcxx-9 on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
clang_9 on aarch64-linux Success
Details
clang_9 on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.cc-wrapper-clang-9, tests.cc-wrapper-libcxx-9 on aarch64-linux Success
Details
tests.cc-wrapper-clang-9, tests.cc-wrapper-libcxx-9 on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Jan 3, 2020
@vcunat vcunat mentioned this pull request Jan 8, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.