Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telega voip support #76779

Open
wants to merge 1 commit into
base: master
from
Open

Telega voip support #76779

wants to merge 1 commit into from

Conversation

@cab404
Copy link
Contributor

@cab404 cab404 commented Jan 1, 2020

Motivation for this change

Add telega.el VoIP support.

Things done

Packaged libtgvoip
Added libtgvoip to telega.el deps
Added a flag to build with voip

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

@cab404 cab404 force-pushed the cab404:telega-voip branch from 6801f17 to f59d835 Jan 1, 2020
@cab404
Copy link
Contributor Author

@cab404 cab404 commented Jan 3, 2020

, libtool
, writeShellScriptBin
}:
clangStdenv.mkDerivation {

This comment has been minimized.

@adisbladis

adisbladis Jan 3, 2020
Member

Could we not put this in emacs-modes? It looks generally useful for non-emacs packages.

This comment has been minimized.

@cab404

cab404 Jan 3, 2020
Author Contributor

Could we not put this in emacs-modes? It looks generally useful for non-emacs packages.

Oof, really not familliar with packaging emacs stuff. You want me to put it inside melpa overrides?

This comment has been minimized.

@cab404

cab404 Jan 3, 2020
Author Contributor

Is clangStdenv required or could we use normal stdenv?

That is a quick solution for libtool prefix errors.

This comment has been minimized.

@adisbladis

adisbladis Jan 3, 2020
Member

No I'd like it to live outside of the emacs infrastructure as it's not really emacs-specific. Probably in pkgs/development/libraries/libtgvoip.

This comment has been minimized.

@cab404

cab404 Jan 3, 2020
Author Contributor

No I'd like it to live outside of the emacs infrastructure as it's not really emacs-specific. Probably in pkgs/development/libraries/libtgvoip.

It's very telega specific (a fork with patches for telega), so it's useless for everything else too. I thought that if one part of telega-server is in melpa overrides, probably all the other parts of it should be there too.

This comment has been minimized.

@cab404

cab404 Jan 7, 2020
Author Contributor

is it okay to put it into expression itself?

}:
clangStdenv.mkDerivation {

name = "libtgvoip";

This comment has been minimized.

@adisbladis

adisbladis Jan 3, 2020
Member

name -> pname & version attributes


nativeBuildInputs = [ pkgconfig ];
buildInputs = [ libopus openssl libpulseaudio alsaLib ];

This comment has been minimized.

@adisbladis

adisbladis Jan 3, 2020
Member

Missing meta attrs.

This comment has been minimized.

@cab404

cab404 Jan 3, 2020
Author Contributor

Missing meta attrs.

Actually I was just thinking that whole this library is telega specific (and certainly not top-level), so added no meta, and no version.

@stale
Copy link

@stale stale bot commented Jul 5, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.