Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telega voip support #76779

Open
wants to merge 1 commit into
base: master
from
Open

Telega voip support #76779

wants to merge 1 commit into from

Conversation

@cab404
Copy link
Contributor

cab404 commented Jan 1, 2020

Motivation for this change

Add telega.el VoIP support.

Things done

Packaged libtgvoip
Added libtgvoip to telega.el deps
Added a flag to build with voip

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

@cab404 cab404 force-pushed the cab404:telega-voip branch from 6801f17 to f59d835 Jan 1, 2020
@cab404

This comment has been minimized.

Copy link
Contributor Author

cab404 commented Jan 3, 2020

, libtool
, writeShellScriptBin
}:
clangStdenv.mkDerivation {

This comment has been minimized.

Copy link
@adisbladis

adisbladis Jan 3, 2020

Member

Could we not put this in emacs-modes? It looks generally useful for non-emacs packages.

This comment has been minimized.

Copy link
@cab404

cab404 Jan 3, 2020

Author Contributor

Could we not put this in emacs-modes? It looks generally useful for non-emacs packages.

Oof, really not familliar with packaging emacs stuff. You want me to put it inside melpa overrides?

This comment has been minimized.

Copy link
@cab404

cab404 Jan 3, 2020

Author Contributor

Is clangStdenv required or could we use normal stdenv?

That is a quick solution for libtool prefix errors.

This comment has been minimized.

Copy link
@adisbladis

adisbladis Jan 3, 2020

Member

No I'd like it to live outside of the emacs infrastructure as it's not really emacs-specific. Probably in pkgs/development/libraries/libtgvoip.

This comment has been minimized.

Copy link
@cab404

cab404 Jan 3, 2020

Author Contributor

No I'd like it to live outside of the emacs infrastructure as it's not really emacs-specific. Probably in pkgs/development/libraries/libtgvoip.

It's very telega specific (a fork with patches for telega), so it's useless for everything else too. I thought that if one part of telega-server is in melpa overrides, probably all the other parts of it should be there too.

This comment has been minimized.

Copy link
@cab404

cab404 Jan 7, 2020

Author Contributor

is it okay to put it into expression itself?

}:
clangStdenv.mkDerivation {

name = "libtgvoip";

This comment has been minimized.

Copy link
@adisbladis

adisbladis Jan 3, 2020

Member

name -> pname & version attributes


nativeBuildInputs = [ pkgconfig ];
buildInputs = [ libopus openssl libpulseaudio alsaLib ];

This comment has been minimized.

Copy link
@adisbladis

adisbladis Jan 3, 2020

Member

Missing meta attrs.

This comment has been minimized.

Copy link
@cab404

cab404 Jan 3, 2020

Author Contributor

Missing meta attrs.

Actually I was just thinking that whole this library is telega specific (and certainly not top-level), so added no meta, and no version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.