Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.JPype1: refactor fix broken build #76784

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@costrouc
Copy link
Contributor

@costrouc costrouc commented Jan 1, 2020

Motivation for this change

The patch that was originally applied in jpype did not seem to be doing anything as the compiler was giving warnings that -x c++ was being ignored. So I removed the patch. Tests looked non trivial to get working. Required openjdk (easy) but then there were some class path issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@costrouc costrouc requested review from FRidh and jonringer as code owners Jan 1, 2020
costrouc added 2 commits Jan 1, 2020
@costrouc costrouc force-pushed the costrouc:python-jpype-fix branch from c5d9acd to ca07888 Jan 1, 2020
@FRidh FRidh changed the base branch from staging-next to master Jan 3, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM

[7 built, 2 copied (0.5 MiB), 0.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76784
6 package built:
python27Packages.JPype1 python27Packages.JayDeBeApi python37Packages.JPype1 python37Packages.JayDeBeApi python38Packages.JPype1 python38Packages.JayDeBeApi
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 7, 2020

@GrahamcOfBorg build python27Packages.JPype1 python27Packages.JayDeBeApi python37Packages.JPype1 python37Packages.JayDeBeApi python38Packages.JPype1 python38Packages.JayDeBeApi

@jonringer jonringer merged commit 41d1ac2 into NixOS:master Jan 7, 2020
15 of 16 checks passed
15 of 16 checks passed
python27Packages.JPype1, python27Packages.JayDeBeApi, python37Packages.JPype1, python37Packages.JayDeBeApi, python38Packages.JPype1, python38Packages.JayDeBeApi on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.JPype1, python27Packages.JayDeBeApi, python37Packages.JPype1, python37Packages.JayDeBeApi, python38Packages.JPype1, python38Packages.JayDeBeApi on aarch64-linux Success
Details
python27Packages.JPype1, python27Packages.JayDeBeApi, python37Packages.JPype1, python37Packages.JayDeBeApi, python38Packages.JPype1, python38Packages.JayDeBeApi on x86_64-darwin Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.