Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.alerta-server: refactor fix broken build #76789

Open
wants to merge 5 commits into
base: staging-next
from

Conversation

@costrouc
Copy link
Contributor

@costrouc costrouc commented Jan 1, 2020

Motivation for this change

Enable all tests and fix broken builds in staging-next. In this case fix alerta-server and some of its dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

costrouc added 5 commits Jan 1, 2020
…tests
@stale
Copy link

@stale stale bot commented Jun 30, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 30, 2020

meta = with lib; {
description = "Python wrapper around Lua and LuaJIT";
homepage = https://github.com/scoder/lupa;

This comment has been minimized.

@doronbehar

doronbehar Sep 11, 2020
Contributor

Suggested change
homepage = https://github.com/scoder/lupa;
homepage = "https://github.com/scoder/lupa";

NixOS/rfcs#45

};

propagatedBuildInputs = [
redis

This comment has been minimized.

@doronbehar

doronbehar Sep 11, 2020
Contributor

Perhaps this should go to buildInputs?

@stale stale bot removed the 2.status: stale label Sep 11, 2020
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 11, 2020

Note the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.