Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcli: init at 1.8.2 #76791

Merged
merged 2 commits into from Jan 2, 2020
Merged

kcli: init at 1.8.2 #76791

merged 2 commits into from Jan 2, 2020

Conversation

@cswank
Copy link

@cswank cswank commented Jan 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
subPackages = [ "." ];

meta = with stdenv.lib; {
description = "A kafka command line browser.";

This comment has been minimized.

@cab404

cab404 Jan 1, 2020
Contributor

dot at the end should be omited iirc

This comment has been minimized.

@cswank

cswank Jan 1, 2020
Author

fixed

@cswank cswank force-pushed the cswank:pkgs/kcli branch from 56046f0 to 05cc127 Jan 1, 2020
maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/development/tools/kcli/default.nix Show resolved Hide resolved
pkgs/development/tools/kcli/default.nix Outdated Show resolved Hide resolved
Craig Swank added 2 commits Jan 2, 2020
@cswank cswank force-pushed the cswank:pkgs/kcli branch from 05cc127 to 26839ae Jan 2, 2020
@ofborg ofborg bot requested a review from kalbasit Jan 2, 2020
@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 2, 2020

@GrahamcOfBorg build kcli

@kalbasit kalbasit merged commit 43e14ef into NixOS:master Jan 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kcli on aarch64-linux Success
Details
kcli on x86_64-darwin Success
Details
kcli on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.