Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-my-aws: init at 20200111 #76793

Merged
merged 2 commits into from Feb 5, 2020
Merged

bash-my-aws: init at 20200111 #76793

merged 2 commits into from Feb 5, 2020

Conversation

@tomberek
Copy link
Contributor

@tomberek tomberek commented Jan 1, 2020

Motivation for this change

Add bash-my-aws to nixpkgs

Things done
  • add package
  • add program module
  • tested on NixOS

Note: the package needs to be initialized by sourcing an alias and bash_completions for some features. Otherwise the bma script in /bin is still functional. Non-NixOS could use eval $(bma-init) that performs the above actions, but that might be the prerogative of upstream.

Another (perhaps better) option is to incorporate into home-manager so we don't have to patch the hard-coded location away.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Create bma-init
@tomberek tomberek force-pushed the tomberek:bash-my-aws/init branch from 7140092 to e5208af Jan 1, 2020
@tomberek
Copy link
Contributor Author

@tomberek tomberek commented Jan 1, 2020

WIP: home-manager approach: https://github.com/tomberek/home-manager/blob/bash-my-aws/init/modules/programs/bash-my-aws.nix

That allows us to remove the entire postFixup phase. But that has less compatibility with non-HomeManager users.

@tomberek tomberek changed the title bash-my-aws: init at 20191231 bash-my-aws: init at 20200111 Jan 12, 2020
@danbst
danbst approved these changes Feb 5, 2020
Copy link
Contributor

@danbst danbst left a comment

😍

@danbst danbst merged commit 437e1f6 into NixOS:master Feb 5, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bash-my-aws on aarch64-linux Success
Details
bash-my-aws on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.