Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tablib: 0.12.1 -> 0.14.0 enable tests remove patches #76795

Closed
wants to merge 3 commits into from

Conversation

@costrouc
Copy link
Contributor

@costrouc costrouc commented Jan 1, 2020

Motivation for this change

Required a backport of openpyxl from 3.0.2 -> 3.0.1. 3.0.2 is broken https://bitbucket.org/openpyxl/openpyxl/issues/1373/broken-writer-with-lxml-defusedxml. Which causes the writer to fail. Enable tests on openpyxl as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

costrouc added 3 commits Jan 1, 2020
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 10, 2020

do you mind targeting master? I need to build 1000+ packages to review this on master.

just a few hundred rebuilds is okay for master

@FRidh FRidh changed the base branch from staging-next to staging Jun 14, 2020
@marsam
Copy link
Contributor

@marsam marsam commented Aug 17, 2020

addressed by #79090

@marsam marsam closed this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.