Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/freeswitch: init #76821

Merged
merged 2 commits into from Jan 30, 2020
Merged

nixos/freeswitch: init #76821

merged 2 commits into from Jan 30, 2020

Conversation

@misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 2, 2020

Motivation for this change

Basic FreeSWITCH module with configuration reload support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

@Infinisil Infinisil left a comment

Nice PR overall! I can see you put some thought into it :)

nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/tests/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
@misuzu misuzu force-pushed the misuzu:freeswitch-module branch from 095e057 to 0c9ef9d Jan 15, 2020
Copy link
Member

@Infinisil Infinisil left a comment

Ah wait, just saw something when rendering the manual. Turns out a few more literalExamples are needed for them to render nicely. I believe literalExample should be used in defaultText and example when the value represents a Nix value and not a string.

nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
nixos/modules/services/misc/freeswitch.nix Outdated Show resolved Hide resolved
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Jan 16, 2020

You can render the manual yourself with nix-build nixos/release.nix -A manualHTML.x86_64-linux to see what it looks like.

@misuzu misuzu force-pushed the misuzu:freeswitch-module branch from 0c9ef9d to 1277b2f Jan 27, 2020
@misuzu
Copy link
Contributor Author

@misuzu misuzu commented Jan 27, 2020

Updated. Example's and Default's looks fine now.

@misuzu misuzu requested a review from Infinisil Jan 27, 2020
@Infinisil
Copy link
Member

@Infinisil Infinisil commented Jan 30, 2020

@GrahamcOfBorg test freeswitch

nixos/tests/all-tests.nix Outdated Show resolved Hide resolved
@misuzu misuzu force-pushed the misuzu:freeswitch-module branch from 1277b2f to 0a43e43 Jan 30, 2020
@misuzu
Copy link
Contributor Author

@misuzu misuzu commented Jan 30, 2020

@GrahamcOfBorg test freeswitch

@Infinisil Infinisil merged commit 2118cdd into NixOS:master Jan 30, 2020
2 checks passed
2 checks passed
tests.freeswitch on aarch64-linux Success
Details
tests.freeswitch on x86_64-linux Success
Details
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Jan 30, 2020
nixos/freeswitch: init

(cherry picked from commit 2118cdd)
anna328p added a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

@misuzu misuzu deleted the misuzu:freeswitch-module branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.