Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grandorgue: init at 0.3.1-r2333 #76824

Merged
merged 2 commits into from Mar 24, 2020
Merged

grandorgue: init at 0.3.1-r2333 #76824

merged 2 commits into from Mar 24, 2020

Conversation

@puzzlewolf
Copy link
Contributor

@puzzlewolf puzzlewolf commented Jan 2, 2020

Motivation for this change

Create a package for grandorgue, a sample based pipe organ simulator.
https://sourceforge.net/projects/ourorgan/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@puzzlewolf puzzlewolf force-pushed the puzzlewolf:grandorgue/init branch 2 times, most recently from eaf2ac3 to 06f0cdd Jan 2, 2020
@puzzlewolf puzzlewolf force-pushed the puzzlewolf:grandorgue/init branch from 06f0cdd to 8d6752d Jan 2, 2020
Copy link
Contributor

@symphorien symphorien left a comment

Thanks for the PR.
The package looks good, except for one nitpick.
I built grandOrgue with nix-review and it seems to work (makes organ-like sound), except that I get this scary warning at startup:

RtMidi error: MidiInAlsa::initialize: error creating ALSA sequencer client object.
RtMidi error: MidiOutAlsa::initialize: error creating ALSA sequencer client object.

Not sure if it is normal.
I am also intrigued at how the open file dialog works even without wrapGAppsHook, but since it works, let's not change anything in this regard.

pkgs/applications/audio/grandorgue/default.nix Outdated Show resolved Hide resolved
@puzzlewolf puzzlewolf force-pushed the puzzlewolf:grandorgue/init branch 2 times, most recently from 73c0790 to 50d3cdb Jan 2, 2020
@puzzlewolf puzzlewolf requested a review from symphorien Feb 6, 2020
@puzzlewolf
Copy link
Contributor Author

@puzzlewolf puzzlewolf commented Feb 6, 2020

I found an answer to the RtMidi error at https://sourceforge.net/p/ourorgan/discussion/962124/thread/9875b915/: it should not occur if the user is a member of the audio group. However, the program works even with the error. So, I think this package should be fine :)

Copy link
Contributor

@symphorien symphorien left a comment

adding myself to the audio group works. Thanks!

Copy link
Contributor

@Valodim Valodim left a comment

works for me.

not sure we can do anything about the audio group thing at package level. there is general advice to that effect already, with reasonable discoverability.

@grahamc
Copy link
Member

@grahamc grahamc commented Mar 24, 2020

Hmm....

$ ./result/bin/GrandOrgue
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm.c:2556:(snd_pcm_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_pcm_pulse.so cannot be opened or _snd_pcm_pulse_open was not defined inside
ALSA lib pcm.c:2556:(snd_pcm_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_pcm_pulse.so cannot be opened or _snd_pcm_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
zsh: segmentation fault (core dumped)  ./result/bin/GrandOrgue

I don't really know what to make of this.

@grahamc
Copy link
Member

@grahamc grahamc commented Mar 24, 2020

The segfault was myfault. I think the only trouble is the license?

@puzzlewolf puzzlewolf force-pushed the puzzlewolf:grandorgue/init branch from 50d3cdb to 5016a76 Mar 24, 2020
@puzzlewolf
Copy link
Contributor Author

@puzzlewolf puzzlewolf commented Mar 24, 2020

Thanks for finding that license mistake 👍

@grahamc grahamc merged commit 66222ad into NixOS:master Mar 24, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
grandorgue on aarch64-linux Success
Details
grandorgue on x86_64-linux Success
Details
@grahamc
Copy link
Member

@grahamc grahamc commented Mar 24, 2020

Thank you!

@puzzlewolf puzzlewolf deleted the puzzlewolf:grandorgue/init branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.