Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corerad: init at v0.1.4 #76825

Merged
merged 2 commits into from Jan 6, 2020
Merged

corerad: init at v0.1.4 #76825

merged 2 commits into from Jan 6, 2020

Conversation

@mdlayher
Copy link
Member

@mdlayher mdlayher commented Jan 2, 2020

Motivation for this change

CoreRAD is a new project I'm working on to create an extensible radvd replacement. I'm running it as of now on my NixOS home router via an overlay, but would like to get it packaged upstream as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

(none as of now)

cc @danderson, per our conversation last night about packaging this

Signed-off-by: Matt Layher <mdlayher@gmail.com>
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

Having a hash mismatch for modules.

hash mismatch in fixed-output derivation '/nix/store/5ahiq2snwf8wgv3j5mw1f0m57rsax2ch-corerad-0.1.1-go-modules':
  wanted: sha256:036b0cqj9ssmcjdvrxvibzchdc3cyxbj868fyv5z81b53xlqn3np
  got:    sha256:0cfjsiiiff0k1v5j837s4jbp02snqrmv08grm69b3wjhr4145886
cannot build derivation '/nix/store/yniqxhhh3wjh32ig0960brxrkwjfk1la-corerad-0.1.1.drv': 1 dependencies couldn't be built
pkgs/tools/networking/corerad/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit Jan 2, 2020
@mdlayher mdlayher force-pushed the mdlayher:mdl-pkg-corerad branch 2 times, most recently from c0a0fa8 to d92c160 Jan 2, 2020
@mdlayher mdlayher changed the title corerad: init at v0.1.1 corerad: init at v0.1.2 Jan 2, 2020
Copy link
Contributor

@jonringer jonringer left a comment

diff LGTM
commits LGTM
executable seems to work

[5 built, 105 copied (827.0 MiB), 189.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76825
1 package built:
corerad
@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

@GrahamcOfBorg build corerad

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

Thanks for the review. This is a bug in the application and I'll resolve it upstream today so this change won't be necessary.

@mdlayher mdlayher force-pushed the mdlayher:mdl-pkg-corerad branch from d92c160 to 5847f2c Jan 6, 2020
@mdlayher mdlayher changed the title corerad: init at v0.1.2 corerad: init at v0.1.4 Jan 6, 2020
@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

Updated to v0.1.4 which also fixes non-Linux support.

[matt@routnerr-2:~/src/nixpkgs]$ nix-build -A corerad
these derivations will be built:                                                         
  /nix/store/if9kbsrcbma7473yq49lv4dwr01q74dl-remove-references-to.drv
  /nix/store/zrlxld4wn7izmjwrnvjvb6hi4yc0rfdf-corerad-0.1.4.drv 
[...]
[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad -init

[matt@routnerr-2:~/src/nixpkgs]$ ./result/bin/corerad
2020/01/06 10:43:55 CoreRAD v0.1.4 (ALPHA) starting with configuration file "corerad.toml"
2020/01/06 10:43:55 failed to run: failed to look up interface "eth0": route ip+net: no such network interface

Ready for another review when you are @jonringer! Thank you.

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

@GrahamcOfBorg build corerad

Signed-off-by: Matt Layher <mdlayher@gmail.com>
@mdlayher mdlayher force-pushed the mdlayher:mdl-pkg-corerad branch from 5847f2c to 0fe232b Jan 6, 2020
@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

@GrahamcOfBorg build corerad

@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

I can't seem to figure out why my local system computes a different modSha256 than the builder, but both seem to work. If it matters, I am importing the package locally on my own machine via /etc/nixos/configuration.nix until it's upstream.

I have updated the PR with what the builder suggests.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

@GrahamcOfBorg build corerad

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 6, 2020

I can't seem to figure out why my local system computes a different modSha256 than the builder

Most common cause is usually overlays which affect a dependency

@jonringer jonringer merged commit 987a5ff into NixOS:master Jan 6, 2020
3 checks passed
3 checks passed
corerad on aarch64-linux Success
Details
corerad on x86_64-darwin Success
Details
corerad on x86_64-linux Success
Details
@mdlayher mdlayher deleted the mdlayher:mdl-pkg-corerad branch Jan 6, 2020
@mdlayher
Copy link
Member Author

@mdlayher mdlayher commented Jan 6, 2020

Thanks for the review and merge!

@mdlayher mdlayher mentioned this pull request Jan 7, 2020
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.