Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NS in emacs-nox #76830

Merged
merged 1 commit into from Jan 2, 2020
Merged

Disable NS in emacs-nox #76830

merged 1 commit into from Jan 2, 2020

Conversation

@ericnorris
Copy link
Contributor

@ericnorris ericnorris commented Jan 2, 2020

Motivation for this change

When installing emacs-nox on darwin, the withNS flag ends up installing a windowed version of emacs. This pull request passes through withNS = false; so that emacs-nox behaves as you'd expect it on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @peti @the-kenny @jwiegley

@matthewbauer matthewbauer merged commit 699e1b4 into NixOS:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.